Fix CircleCI build#7160
Merged
Merged
Conversation
The phobos Circle CI build recently started failing, while the dmd one is fine. The difference is that the dmd build is using has `HOST_DMD_VER` set to `2.079.1`, instead of `2.078.1`.
Contributor
|
Thanks for your pull request, @ZombineDev! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7160" |
thewilsonator
approved these changes
Aug 29, 2019
Member
Author
|
Nope, it looks like there's more changes. Since the latest developments around
|
Member
Author
|
Found the root cause: dlang/dmd#10212 (comment) |
PetarKirov
force-pushed
the
upgrade-circle-ci
branch
2 times, most recently
from
6a6bdc3 to
7e15364
Compare
…posix.mak PR dlang/dmd#10212 broke building `dmd/src/posix.mak` with `BUILD=debug`. Use `build.d` instead.
PetarKirov
force-pushed
the
upgrade-circle-ci
branch
from
fc41a68 to
de6c26e
Compare
PetarKirov
changed the title
Member
Author
|
CircleCI is now green -> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit (see GH message history if needed):
HOST_DMD_VERfrom2.078.1to2.079.1, to match the dmd CircleCI build../dmd/scr/build.d, instead of../dmd/src/posix.mak, becauseBUILD=debugis broken since Second round of makefile/build.d consolidation dmd#10212 (comment)gdbdownload step intoinstall_deps