Add java.util.Locale compatibility runtime - #171
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 83.14% 83.71% +0.56%
==========================================
Files 170 171 +1
Lines 12126 12867 +741
==========================================
+ Hits 10082 10771 +689
- Misses 2044 2096 +52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 964723ca38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adds a minimal java.util.Locale runtime implementation to the java_runtime crate, wires it into the runtime class loader, and introduces tests to validate basic Locale behavior in the JVM harness.
Changes:
- Implement
java/util/Localeruntime class (constructors, constants, default locale, accessors, equality/hashCode/clone/toString, and basic ISO/display helpers). - Register
Localein the runtime loader and export it fromjava_runtime::classes::java::util. - Add
java_runtimetests for Locale constants, constructors, default-locale behavior, null rejection, and unsupported ISO3 handling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| java_runtime/src/classes/java/util/locale.rs | New java.util.Locale runtime class implementation and behavior. |
| java_runtime/src/loader.rs | Registers Locale so it can be resolved/loaded at runtime. |
| java_runtime/src/classes/java/util.rs | Adds locale module + re-exports Locale. |
| java_runtime/tests/classes/java/util/test_locale.rs | New tests for Locale constants/constructors/default/edge cases. |
| java_runtime/tests/classes/java/util/mod.rs | Includes the new test_locale module in the test suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Validation