Skip to content

add missing abstract methods in SerializedOfflinePlayer - #2759

Closed
wuangg wants to merge 1 commit into
dmulloy2:masterfrom
wuangg:add-missing-overrides
Closed

add missing abstract methods in SerializedOfflinePlayer#2759
wuangg wants to merge 1 commit into
dmulloy2:masterfrom
wuangg:add-missing-overrides

Conversation

@wuangg

@wuangg wuangg commented Jan 24, 2024

Copy link
Copy Markdown

Add some missing abstract methods from OfflinePlayer that introduced in recent Spigot 1.20.4 API to SerializedOfflinePlayer to fix a compile error.

Fixes #2758.

@derklaro derklaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really make this class abstract and implement all methods that do nothing in runtime using ByteBuddy (or just remove it, if possible, but I guess not)...

@wuangg

wuangg commented Feb 1, 2024

Copy link
Copy Markdown
Author

Close this in favor of #2777.

@wuangg wuangg closed this Feb 1, 2024
@wuangg
wuangg deleted the add-missing-overrides branch February 1, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation Failure: SerializedOfflinePlayer Missing getLocation Override

2 participants