feat: add blkio device options to docker container update#7031
Open
acouvreur wants to merge 2 commits into
Open
feat: add blkio device options to docker container update#7031acouvreur wants to merge 2 commits into
acouvreur wants to merge 2 commits into
Conversation
Closes docker#3325 Related to moby/moby#52651 Signed-off-by: Alexis Couvreur <alexiscouvreur.pro@gmail.com>
acouvreur
force-pushed
the
container-update-blkio-device-throttle
branch
2 times, most recently
from
11ba624 to
1c145a3
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Alexis Couvreur <alexiscouvreur.pro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3325
Related to moby/moby#52651
- What I did
Add 5 options to
docker container updateto control the device blkio throttle.- How I did it
I simply added the same options from the create command to the update command to be able to pass the blkio device arguments for the update.
- How to verify it
The current version of the moby/moby library does not forward those arguments even though they exist in the struct.
You need to set the moby/moby version to the one in moby/moby#52651 and then create a docker container with a certain blkio device throttle configuration and then update it using docker container update. Then you can inspect the container for those new values.
- Human readable description for the release notes
docker container update can now update the blkio device weights/IOPs
- A picture of a cute animal (not mandatory but encouraged)