Skip to content

Remove duplicate [Theory] and [MemberData] from ROSequenceStreamConformanceTests.Seek_PastEnd_ReadReturns0 #129979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

Remove duplicate [Theory] and [MemberData] from ROSequenceStreamConformanceTests.Seek_PastEnd_ReadReturns0 #129979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df27daa
Remove duplicate [Theory] and [MemberData] from ROSequenceStreamConfo…
Copilot Jun 29, 2026
935dd2d
Fix trimmed MemberData resolution for System.Memory conformance test …
Copilot Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...braries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.IO;
using System.Collections.Generic;
using System.IO.Tests;
using System.Threading.Tasks;

namespace System.Memory.Tests
{
public class NativeReadOnlyMemoryStreamConformanceTests : StandaloneStreamConformanceTests
{
public new static IEnumerable<object[]> AllSeekModes() => StreamConformanceTests.AllSeekModes();

protected override bool CanSeek => true;
protected override bool CanSetLength => false;
protected override bool NopFlushCompletesSynchronously => true;
Expand All @@ -28,4 +31,3 @@ public class NativeReadOnlyMemoryStreamConformanceTests : StandaloneStreamConfor
protected override Task<Stream?> CreateReadWriteStreamCore(byte[]? initialData) => Task.FromResult<Stream?>(null);
}
}

4 changes: 3 additions & 1 deletion ...braries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.IO;
using System.Collections.Generic;
using System.IO.Tests;
using System.Threading.Tasks;

namespace System.Memory.Tests
{
public class NativeWritableMemoryStreamConformanceTests : StandaloneStreamConformanceTests
{
public new static IEnumerable<object[]> AllSeekModes() => StreamConformanceTests.AllSeekModes();

protected override bool CanSeek => true;
protected override bool CanSetLength => false;
protected override bool NopFlushCompletesSynchronously => true;
Expand Down Expand Up @@ -36,4 +39,3 @@ public class NativeWritableMemoryStreamConformanceTests : StandaloneStreamConfor
}
}
}

5 changes: 3 additions & 2 deletions src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
using System.IO;
using System.Buffers;
using System.Collections.Generic;
using System.IO.Tests;
using System.Threading.Tasks;
using Xunit;
Expand All @@ -10,6 +11,8 @@ namespace System.Memory.Tests
{
public class ROSequenceStreamConformanceTests : StandaloneStreamConformanceTests
{
public new static IEnumerable<object[]> AllSeekModes() => StreamConformanceTests.AllSeekModes();

protected override bool CanSeek => true;
protected override bool CanSetLength => false;
protected override bool NopFlushCompletesSynchronously => true;
Expand All @@ -35,8 +38,6 @@ protected virtual ReadOnlySequence<byte> CreateSequence(byte[] data)
protected override Task<Stream?> CreateReadWriteStreamCore(byte[]? initialData)
=> Task.FromResult<Stream?>(null);

[Theory]
[MemberData(nameof(AllSeekModes))]
public override async Task Seek_PastEnd_ReadReturns0(SeekMode mode)
{
await base.Seek_PastEnd_ReadReturns0(mode);
Expand Down
Loading