Enable tiering for async versions#129985
Open
jakobbotsch wants to merge 1 commit into
Open
Conversation
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR’s tiered compilation eligibility rules to allow runtime async “async version” methods to participate in tiering (and thus become candidates for tiered PGO), while continuing to exclude wrapper-thunk async methods that are not supported.
Changes:
- Relaxed the tiering exclusion for async thunk methods to allow those that
SupportsAsyncVersionCodegen(). - Updated the in-code comment describing async tiering behavior (though the wording could be made more precise; see review comments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like this may be all that's needed.
Fix #115096