Skip to content

Add ActiveIssue to the new self_override_generic test#130004

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:disa
Jun 30, 2026
Merged

Add ActiveIssue to the new self_override_generic test#130004
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:disa

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

Also update ActiveIssue on the self_override5.il test which is yet another thing the batch update in #123248 did wrong.

Also update ActiveIssue on the self_override5.il test which is yet another thing the batch update in dotnet#123248 did wrong.
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates IL-based loader/classloader tests to use the correct inline ActiveIssue metadata for NativeAOT, aligning with the post-#123248 approach of expressing test exclusions directly in the test source.

Changes:

  • Fixes self_override5.il to use the issue URL (instead of descriptive text) in the ActiveIssueAttribute payload.
  • Adds Microsoft.DotNet.XUnitExtensions / TestLibrary extern references and an ActiveIssueAttribute to the new self_override_generic.il test to gate it on NativeAOT.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tests/Loader/classloader/MethodImpl/Desktop/self_override5.il Corrects ActiveIssueAttribute argument to the canonical GitHub issue URL for NativeAOT gating.
src/tests/Loader/classloader/MethodImpl/Desktop/self_override_generic.il Adds required extern assemblies and introduces ActiveIssueAttribute for NativeAOT gating on the generic MethodImpl override test.

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

/ba-g the macos globalization issue was fixed and the underlying issue is now closed, so it doesn't match.

@MichalStrehovsky MichalStrehovsky merged commit 5b16e5d into dotnet:main Jun 30, 2026
107 of 119 checks passed
@MichalStrehovsky MichalStrehovsky deleted the disa branch June 30, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants