Add ActiveIssue to the new self_override_generic test#130004
Merged
Conversation
Also update ActiveIssue on the self_override5.il test which is yet another thing the batch update in dotnet#123248 did wrong.
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IL-based loader/classloader tests to use the correct inline ActiveIssue metadata for NativeAOT, aligning with the post-#123248 approach of expressing test exclusions directly in the test source.
Changes:
- Fixes
self_override5.ilto use the issue URL (instead of descriptive text) in theActiveIssueAttributepayload. - Adds
Microsoft.DotNet.XUnitExtensions/TestLibraryextern references and anActiveIssueAttributeto the newself_override_generic.iltest to gate it on NativeAOT.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/Loader/classloader/MethodImpl/Desktop/self_override5.il | Corrects ActiveIssueAttribute argument to the canonical GitHub issue URL for NativeAOT gating. |
| src/tests/Loader/classloader/MethodImpl/Desktop/self_override_generic.il | Adds required extern assemblies and introduces ActiveIssueAttribute for NativeAOT gating on the generic MethodImpl override test. |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Jun 29, 2026
This was referenced Jun 30, 2026
Open
Open
Member
Author
|
/ba-g the macos globalization issue was fixed and the underlying issue is now closed, so it doesn't match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update ActiveIssue on the self_override5.il test which is yet another thing the batch update in #123248 did wrong.