Disable metadata generic attribute decoder test on MacCatalyst#130009
Merged
MichalStrehovsky merged 2 commits intoJun 30, 2026
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CustomAttributeDecoderTests on maccatalyst
Disable metadata generic attribute decoder test on MacCatalyst
Jun 30, 2026
jkotas
approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the System.Reflection.Metadata decoding test suite to skip TestCustomAttributeDecoderGenericUsingReflection on MacCatalyst, aligning the platform skip behavior with existing Apple mobile exclusions.
Changes:
- Extend the existing
ActiveIssueskip for issue #60579 to includeTestPlatforms.MacCatalystforTestCustomAttributeDecoderGenericUsingReflection.
MichalStrehovsky
approved these changes
Jun 30, 2026
Member
|
Uh, looks like marking the PR as ready for review is also considered a "Push" somehow? 
@dotnet/ilc-contrib could someone else approve? Neither me nor Jan can approve :( |
vitek-karas
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCustomAttributeDecoderGenericUsingReflectionis failing on MacCatalyst CoreCLR due to mobile-specific reflection enum type resolution behavior.ActiveIssueplatform skip for this test from iOS/tvOS to include MacCatalyst.