Fix NativeAOT assembly name mangling collisions

src/coreclr/tools/Common/Compiler/NativeAotNameMangler.cs

@@ -129,6 +129,7 @@ private static Utf8String SanitizeNameWithHash(Utf8String literal, byte[] hash =
         /// Dictionary given a mangled name for a given <see cref="TypeDesc"/>
         /// </summary>
         private Dictionary<TypeDesc, Utf8String> _mangledTypeNames = new Dictionary<TypeDesc, Utf8String>();
+        private Dictionary<EcmaAssembly, Utf8String> _mangledAssemblyNames = new Dictionary<EcmaAssembly, Utf8String>();
 
         /// <summary>
         /// Given a set of names <param name="set"/> check if <param name="origName"/>
@@ -195,6 +196,87 @@ protected Utf8String NestMangledName(Utf8String name)
             return Utf8String.Concat(EnterNameScopeSequence, name, ExitNameScopeSequence);
         }
 
+        private Utf8String GetMangledAssemblyName(EcmaAssembly assembly)
+        {
+            lock (this)
+            {
+                if (_mangledAssemblyNames.TryGetValue(assembly, out Utf8String mangledName))
+                    return mangledName;
+
+                return ComputeMangledAssemblyName(assembly);
+            }
+        }
+
+        private Utf8String ComputeMangledAssemblyName(EcmaAssembly assembly)
+        {
+            lock (this)
+            {
+                if (!_mangledAssemblyNames.TryGetValue(assembly, out Utf8String name))
+                {
+                    CompilerTypeSystemContext context = (CompilerTypeSystemContext)assembly.Context;
+                    var assemblies = new List<EcmaAssembly>(context.InputFilePaths.Count + context.ReferenceFilePaths.Count);
+                    var assemblySet = new HashSet<EcmaAssembly>();
+                    foreach (string filePath in context.InputFilePaths.Values)
+                    {
+                        EcmaAssembly candidateAssembly = (EcmaAssembly)context.GetModuleFromPath(filePath).Assembly;
+                        if (assemblySet.Add(candidateAssembly))
+                            assemblies.Add(candidateAssembly);
+                    }
+                    foreach (string filePath in context.ReferenceFilePaths.Values)
+                    {
+                        EcmaAssembly candidateAssembly = (EcmaAssembly)context.GetModuleFromPath(filePath).Assembly;
+                        if (assemblySet.Add(candidateAssembly))
+                            assemblies.Add(candidateAssembly);
+                    }
+                    assemblies.Sort(CompareAssembliesForMangling);
+
+                    var deduplicator = new HashSet<Utf8String>();
+                    foreach (EcmaAssembly candidateAssembly in assemblies)
+                    {
+                        if (_mangledAssemblyNames.TryGetValue(candidateAssembly, out Utf8String existingMangledName))
+                        {
+                            deduplicator.Add(existingMangledName);
+                            continue;
+                        }
+
+                        string candidateAssemblyName = candidateAssembly.GetName().Name;
+                        bool isSystemPrivate = IsSystemPrivateAssemblyName(candidateAssemblyName);
+                        string prefixAssemblyName = isSystemPrivate
+                            ? string.Concat("S.P.", candidateAssemblyName.AsSpan(15))
+                            : candidateAssemblyName;
+
+                        name = SanitizeName(new Utf8String(prefixAssemblyName));
+
+                        if (!isSystemPrivate)
+                            name = DisambiguateName(name, deduplicator);
+
+                        deduplicator.Add(name);
+                        _mangledAssemblyNames.Add(candidateAssembly, name);
+                    }
+
+                    name = _mangledAssemblyNames[assembly];
+                }
+                return name;
+            }
+
+            static int CompareAssembliesForMangling(EcmaAssembly left, EcmaAssembly right)
+            {
+                string leftName = left.GetName().Name;
+                string rightName = right.GetName().Name;
+                bool leftSystemPrivate = IsSystemPrivateAssemblyName(leftName);
+                bool rightSystemPrivate = IsSystemPrivateAssemblyName(rightName);
+                if (leftSystemPrivate != rightSystemPrivate)
+                    return leftSystemPrivate ? -1 : 1;
+
+                return string.CompareOrdinal(leftName, rightName);
+            }
+
+            static bool IsSystemPrivateAssemblyName(string assemblyName)
+            {
+                return assemblyName.StartsWith("System.Private.", StringComparison.Ordinal);
+            }
+        }
+
         /// <summary>
         /// If given <param name="type"/> is an <see cref="EcmaType"/> precompute its mangled type name
         /// along with all the other types from the same module as <param name="type"/>.
@@ -215,15 +297,7 @@ private Utf8String ComputeMangledTypeName(TypeDesc type)
                     {
                         bool isSystemModule = ecmaType.Module == ecmaType.Context.SystemModule;
 
-                        string assemblyName = ((EcmaAssembly)ecmaType.Module).GetName().Name;
-                        bool isSystemPrivate = assemblyName.StartsWith("System.Private.");
-
-                        // Abbreviate System.Private to S.P. This might conflict with user defined assembly names,
-                        // but we already have a problem due to running SanitizeName without disambiguating the result
-                        // This problem needs a better fix.
-                        if (isSystemPrivate)
-                            assemblyName = string.Concat("S.P.", assemblyName.AsSpan(15));
-                        Utf8String prependAssemblyName = SanitizeName(new Utf8String(assemblyName));
+                        Utf8String prependAssemblyName = GetMangledAssemblyName((EcmaAssembly)ecmaType.Module);
 
                         var deduplicator = new HashSet<Utf8String>();
 

src/coreclr/tools/aot/ILCompiler.Compiler.Tests/ILCompiler.Compiler.Tests.Assets/ILCompiler.Compiler.Tests.Assets.csproj

@@ -12,6 +12,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <Compile Remove="ManglerCollision.*\**" />
     <ProjectReference Include="..\..\..\..\nativeaot\Test.CoreLib\src\Test.CoreLib.csproj" />
   </ItemGroup>
 

src/tests/nativeaot/SmokeTests/AssemblyNameCollision/AssemblyNameCollision.cs

@@ -0,0 +1,19 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+extern alias AssemblyWithDot;
+extern alias AssemblyWithUnderscore;
+
+class Program
+{
+    public static int Main()
+    {
+        if (new AssemblyWithDot::TestNamespace.TestType().Value != "A.B")
+            return 101;
+
+        if (new AssemblyWithUnderscore::TestNamespace.TestType().Value != "A_B")
+            return 102;
+
+        return 100;
+    }
+}

src/tests/nativeaot/SmokeTests/AssemblyNameCollision/AssemblyNameCollision.csproj

@@ -0,0 +1,6 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <ItemGroup>
+    <ProjectReference Include="AssemblyWithDot\AssemblyWithDot.csproj" Aliases="AssemblyWithDot" />
+    <ProjectReference Include="AssemblyWithUnderscore\AssemblyWithUnderscore.csproj" Aliases="AssemblyWithUnderscore" />
+  </ItemGroup>
+</Project>

src/tests/nativeaot/SmokeTests/AssemblyNameCollision/AssemblyWithDot/AssemblyWithDot.csproj

@@ -0,0 +1,5 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <AssemblyName>A.B</AssemblyName>
+  </PropertyGroup>
+</Project>

src/tests/nativeaot/SmokeTests/AssemblyNameCollision/AssemblyWithDot/TestType.cs

@@ -0,0 +1,9 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace TestNamespace;
+
+public sealed class TestType
+{
+    public string Value => "A.B";
+}

src/tests/nativeaot/SmokeTests/AssemblyNameCollision/AssemblyWithUnderscore/AssemblyWithUnderscore.csproj

@@ -0,0 +1,5 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <AssemblyName>A_B</AssemblyName>
+  </PropertyGroup>
+</Project>

src/tests/nativeaot/SmokeTests/AssemblyNameCollision/AssemblyWithUnderscore/TestType.cs

@@ -0,0 +1,9 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace TestNamespace;
+
+public sealed class TestType
+{
+    public string Value => "A_B";
+}