[release/11.0-preview6] Fix async resumption stub with byref parameters#130022
Open
github-actions[bot] wants to merge 3 commits into
Open
[release/11.0-preview6] Fix async resumption stub with byref parameters#130022github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
It is not valid IL to initialize a byref local with `initobj`. Just load the value of these directly. We had a test for byref parameters, but it did not suspend and did not result in creation of a resumption stub. The test case requires suspension + NoInlining to guarantee a suspension point is created.
Contributor
|
Tagging subscribers to this area: @agocke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #129999 to release/11.0-preview6
/cc @jakobbotsch
Customer Impact
A Task-returning method
Awith a byref parameter may cause the runtime to throw anInvalidProgramExceptionif directly returning the result of another Task-returning methodB(), the task returned byBsuspends and also one of the following is true:Ais marked with[MethodImpl(MethodImplOptions.NoInlining)]BreturnsTask<T>andAreturnsTaskIn these cases the runtime produces an internal IL stub with invalid IL. The invalid IL tries to zero a byref local using
initobj, which is not legal IL. Reported by ASP.NET in #129990.Regression
This issue exists since runtime async was introduced, but #128384 made it possible to hit this issue from C# code.
Testing
Unit test introduced.
Risk
Low. Adjust IL emission to load a
byrefzero withoutinitobj.