Skip to content

Fix case-sensitive path comparison in GlobalSettingsTemplatePackageProvider.EnsureInstallPrerequisites #55105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Happypig375 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix case-sensitive path comparison in GlobalSettingsTemplatePackageProvider.EnsureInstallPrerequisites #55105

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21ee344
Fix case-sensitive path comparison when detecting already-installed t…
Happypig375 Jul 1, 2026
78c6d3e
Omit using System
Happypig375 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...osoft.TemplateEngine.Edge/BuiltInManagedProvider/GlobalSettingsTemplatePackageProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using Microsoft.Extensions.Logging;
Comment thread
Happypig375 marked this conversation as resolved.
Outdated
using Microsoft.TemplateEngine.Abstractions;
using Microsoft.TemplateEngine.Abstractions.Installer;
Expand Down Expand Up @@ -260,7 +261,7 @@ private async Task<UpdateResult> UpdateAsync(List<TemplatePackageData> packages,
var packages = await GetAllTemplatePackagesAsync(cancellationToken).ConfigureAwait(false);

//check if the package with same identifier is already installed
if (packages.OfType<IManagedTemplatePackage>().FirstOrDefault(s => s.Identifier == identifier && s.Installer == installer) is IManagedTemplatePackage packageToBeUpdated)
if (packages.OfType<IManagedTemplatePackage>().FirstOrDefault(s => string.Equals(s.Identifier, identifier, StringComparison.OrdinalIgnoreCase) && s.Installer == installer) is IManagedTemplatePackage packageToBeUpdated)
{
//if same version is already installed - return
if (!forceUpdate && packageToBeUpdated.Version == version)
Expand Down
Loading