Rename SDKCustomCreateTestWorkItemsWithTestExclusion to CreateHelixTestWorkItems#55122
Open
Evangelink wants to merge 1 commit into
Open
Rename SDKCustomCreateTestWorkItemsWithTestExclusion to CreateHelixTestWorkItems#55122Evangelink wants to merge 1 commit into
SDKCustomCreateTestWorkItemsWithTestExclusion to CreateHelixTestWorkItems#55122Evangelink wants to merge 1 commit into
Conversation
…stWorkItems Addresses PR review feedback that the task name was unwieldy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the compiled MSBuild task used by the SDK’s custom Helix test runner infrastructure from SDKCustomCreateTestWorkItemsWithTestExclusion to CreateHelixTestWorkItems, and updates the corresponding UsingTask declaration and invocation in TestRunner.targets to match.
Changes:
- Renamed the MSBuild task class (and file) to
CreateHelixTestWorkItems. - Updated
TestRunner.targetsto use the new task name in both<UsingTask ... />and the task call site.
Show a summary per file
| File | Description |
|---|---|
| test/test-runner/TestRunner.targets | Updates the UsingTask mapping and the task invocation element name to CreateHelixTestWorkItems. |
| test/HelixTasks/CreateHelixTestWorkItems.cs | Renames the task class to CreateHelixTestWorkItems (file moved/renamed accordingly). |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #55099 addressing @MichaelSimons's review feedback:
Renames the MSBuild custom task class from
SDKCustomCreateTestWorkItemsWithTestExclusionto the shorter, clearerCreateHelixTestWorkItems.Changes
test/HelixTasks/SDKCustomCreateTestWorkItemsWithTestExclusion.cs→test/HelixTasks/CreateHelixTestWorkItems.cs(viagit mv, class renamed).test/test-runner/TestRunner.targets: updated theUsingTask TaskName=…declaration and the task invocation to match the renamed class.Naming-only cleanup — no functional change intended.
Validation
HelixTasks.csprojbuilds clean (0 warnings, 0 errors).SDKCustomXUnit*Helix infrastructure to a runner-neutral name #55099, the rename touches a compiled MSBuild task whoseUsingTaskname must match the class name exactly, and is fully validated only by a green Helix run.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com