wip: Sasl client settings auto - #1609
Conversation
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (8)authid These words are not needed and should be removedFROP tohdrTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:stephanbosch/documentation.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.26/apply.pl' |
perl - 'https://github.com/dovecot/documentation/actions/runs/33138522316/attempts/1' &&
git commit -m 'Update check-spelling metadata'If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
|
||
| imapc_sasl_mechanisms: { | ||
| deprecated: { | ||
| settings_auth_debug_deprecated: ` |
There was a problem hiding this comment.
definitely not settings_auth_debug_deprecated
| Mechanisms are attempted in the order of configuration, so preferred mechanisms | ||
| should be configured first. If [[setting,client_auth_mechanism]] is set | ||
| outside the scope of this filter, the indicated mechanism is used with settings | ||
| in that context (a client_auth filter block for that mechanism is not used). |
There was a problem hiding this comment.
`client_auth`. But .. I don't understand what this sentence is trying to say. I suppose it should be its own paragraph with an example. If that is even something that should be done at all? Maybe this text belongs to client_auth_mechanism setting anyway?
| client_auth_password = frop | ||
|
|
||
| client_auth SCRAM-SHA-256 { } | ||
| client_auth SCRAM-SHA-1 { } |
|
|
||
| client_auth_mechanism = PLAIN | ||
| client_auth_authzid = mail-out | ||
| client_auth_password = frop |
There was a problem hiding this comment.
I guess this shows the configuration works like this, but is it something we actually want to encourage? I'm guessing not -> remove it.
| values: setting_types.STRING, | ||
| text: ` | ||
| The authorization identity to be used after authenticating as a client to a | ||
| remote service. |
There was a problem hiding this comment.
Should this default to %{user}?
| values: setting_types.STRING, | ||
| text: ` | ||
| The password to be used for authenticating as a client to a remote service. This | ||
| is the password belonging to the authentication identity \`client_auth_authid\`.` |
There was a problem hiding this comment.
Are we now reusing this client_auth_password for too many things? Should we for example have instead client_auth_oauth2_token setting?
2 participants
JIRA: DOV-9242