Repository navigation
feat(api): sync UniParser to v1.3 client APIs - #23
Merged
Merged
Conversation
LeoMY1
approved these changes
Aug 2, 2026
LeoMY1
left a comment
Collaborator
There was a problem hiding this comment.
Improvement suggestions
All comments below are non-blocking and may be addressed in this or a follow-up PR:
- Consider checking the HTTP status code for TOS uploads so non-standard JSON error responses cannot be misclassified as successful.
- Add consistent fallback behavior for Markdown and LaTeX formatting of empty or malformed tables.
- Preserve server-provided metadata such as
methodduring recursiveGroupedResultconversion. - Extend unknown-field filtering to nested models such as
ReactionandReactionComponent. - Clarify the compatibility behavior of
token="": normalize it toNoneor document the stricter validation. - As follow-up maintenance, align Ruff’s Python target, add Python 3.12 CI coverage, and pin Ruff for reproducible checks.
Verdict
Approve
The implementation is sound, the primary feature set is complete, and the current test coverage provides sufficient confidence for merge. The remaining comments concern edge cases, forward compatibility, and defensive error handling; they do not affect the main v1.3 client workflow and should not block this PR.
I recommend merging the PR and tracking these suggestions as follow-up improvements.
TimothyZero
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync the customer-facing
UniParser-Toolsclient with the supported APIs in UniParserrelease/v1.3.The implementation was validated against upstream commit
e6f9694.Changes
Shared HTTP transport
Parse submission APIs
Update
trigger_file(),trigger_snip(), andtrigger_url()with release/v1.3 options, including:Add TOS upload helpers:
request_tos_upload_links()upload_files_to_tos()Presigned TOS uploads do not carry the UniParser API key, and upload credentials are removed from high-level results.
Result APIs and data models
Update:
get_result()get_formatted()get_third_party_output()Add the corresponding release/v1.3 result fields and recursive conversion support while preserving positional-constructor compatibility.
Service information APIs
Expose:
health()version()get_constants()These allow clients to inspect available model versions, service capabilities, and current constants.
Read-only account APIs
Add
UniParserAccountClient, also available throughparser.account, with:Documentation and packaging
uniparser_tools.>=3.11, matching the pinned dependencies.