fix: avoid panics on invalid inspect request arguments#1965
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
00efe73 to
da832de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
nydus-image inspect --requestcan still panic on bad args. Easy to hit with a typo, pretty meh.Related Issues
Related #705
Change Details
Parse
chunk OFFSETlikeicheck INODE, return normal errors in request mode, and add regression tests. Tiny fix, keeps valid requests working the same.Test Results
cargo test -q --bin nydus-imageRepro before:
cargo run -q --bin nydus-image -- inspect tests/texture/bootstrap/rafs-v5.boot --request 'chunk abc'cargo run -q --bin nydus-image -- inspect tests/texture/bootstrap/rafs-v5.boot --request 'icheck abc'Before: panic
Now:
Error: invalid arguments in inspect request 'chunk abc'Now:
Error: invalid arguments in inspect request 'icheck abc'Valid request check:
cargo run -q --bin nydus-image -- inspect tests/texture/bootstrap/rafs-v5.boot --request 'stats'Change Type
Self-Checklist