Repository navigation
Fix/list pagination 50 cap - #542
Merged
Merged
Conversation
Manage tables page client-side over whatever the list request returned, but DfBaseCrudService.getAll defaulted to limit=50 while include_count still reported the full total. With more than 50 services in one API Types group (customer: 96 scripting services) the paginator showed "51 - 60 of 96" over an empty table with the "Create a service" empty state, and no further request was ever made. History: #234 (944cd19, May 2024) commented out the server-side refetch in changePage and moved paging client-side, raising the default limit 10 -> 100 to compensate. 9fc4acb (Sep 2024) then lowered the default to 50 inside an unrelated splash-screen change, which is the cap every release since 7.0.1 ships. - getAll and getEventScripts default to limit=0 (all rows; the server still caps at max_records_returned). Covers every ServiceRoutes page (Database, Scripting, Network, File, Utility, Authentication, Logs, Platform APIs, AI) and Event Scripts, which truncated at 50 silently. - API Docs: drop the `100 || limit` (always 100) and the resolver's limit of 100, which cut the list at 100 services. - Search no longer limits results to one page size, which left every page after the first empty, and now resets the paginator to page one.
Rebuilt on top of main (a5a74c7). Every chunk is renamed because main's dist was last built with a different node_modules state; this build is from the lockfile-exact install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the default loading value of services on the front end was capped at 50, the UI would list xx number of services however after paging past 50 no services would display in the list.