Skip to content

send the column property to the custom type handler #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veilevil wants to merge 9 commits into
base: master
Choose a base branch
from
Open

send the column property to the custom type handler #678

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fef3188
Disable cache by default. Closes #672
dxg Oct 19, 2015
de783cc
send the column property to the custom type handler
veilevil Nov 16, 2015
f6737d5
send the column proterty to the custom type handler
veilevil Nov 16, 2015
4d9755d
remove omit prop when create instance
veilevil Dec 10, 2015
379112b
Merge branch 'master' into version2.2
veilevil Dec 10, 2015
e45282c
fixed 'only' bugs
veilevil Dec 11, 2015
7df3c03
only update v2.2
veilevil Dec 15, 2015
a610c43
fix bug
veilevil Dec 16, 2015
fbe2fa4
extendsto bug fix
veilevil Dec 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Drivers/DML/mysql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ Driver.prototype.valueToProperty = function (value, property) {
default:
customType = this.customTypes[property.type];
if(customType && 'valueToProperty' in customType) {
value = customType.valueToProperty(value);
value = customType.valueToProperty(value,property);
}
}
return value;
Expand All @@ -283,7 +283,7 @@ Driver.prototype.propertyToValue = function (value, property) {
default:
customType = this.customTypes[property.type];
if(customType && 'propertyToValue' in customType) {
value = customType.propertyToValue(value);
value = customType.propertyToValue(value),property;

@dresende dresende Nov 16, 2015

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this your intention? Shouldn't it be like the other change?

}
}
return value;
Expand Down