stop login callback re-redeeming the oauth code on reload#1943
Open
efstajas wants to merge 2 commits into
Open
stop login callback re-redeeming the oauth code on reload#1943efstajas wants to merge 2 commits into
efstajas wants to merge 2 commits into
Conversation
the redeem takes ~1.5s (github exchange), which on slow connections invites a reload mid-flight. the reloaded callback page then re-posted the same single-use code, got "OAuth session already used" back, and showed the generic error screen — even when the first attempt had succeeded server-side with its response lost. mark the code as attempted in sessionStorage before redeeming; a later load seeing the marker skips straight to the login page (which bounces to backTo if a session exists, and re-authorizes instantly otherwise). also surface the backend's actual error message instead of blaming github for everything, and carry backTo through the try-again button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the redeem takes ~1.5s (github exchange), which on slow connections invites a reload mid-flight. the reloaded callback page then re-posted the same single-use code, got "OAuth session already used" back, and showed the generic error screen — even when the first attempt had succeeded server-side with its response lost.
mark the code as attempted in sessionStorage before redeeming; a later load seeing the marker skips straight to the login page (which bounces to backTo if a session exists, and re-authorizes instantly otherwise). also surface the backend's actual error message instead of blaming github for everything, and carry backTo through the try-again button.