Repository navigation
fix(release): make the 2.3.0 candidate acceptance pass (#253) - #265
Merged
Merged
Conversation
#253) The 2.3.0 candidate could not build type-bridge-core from its sdist: cargo metadata resolves optional path dependencies, and the bindings' optional type-bridge-perf was missing. Including it is not enough, because its pipelines feature names the Rust SDK, the CLI and their dev-dependency graph. The bindings use only the stage layer, which needs nothing but tracing. - New private crate type-bridge-perf-stages holds the stage layer; type-bridge-perf re-exports it as stages for its pipelines binary. - The Python, Node and C bindings' perf-stages feature links the leaf crate, still optional and off by default. - The core sdist includes crates/perf-stages as an explicit raw source root, like orm-derive; the validator, release inventory and their tests name the new crate. - Rebind the C distribution and broad-case ledger digests for the changed C manifest. A maturin 1.14.1 sdist of the result passes cargo metadata. Parts of #253
…253) Generated 2.3 packages default to the typedb-3.13.6/v1 profile, while the release acceptance service is TypeDB 3.12.3. The exact-wheel Python application and the server OCI's external Rust application therefore refused the server. Select typedb-3.12.1/v1 there, as CI does for its 3.12.3 lanes. Parts of #253
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
) The parity job tests fixtures that build-python and pack-node-package generate. Those still used the 2.3 default profile, typedb-3.13.6/v1, so the 3.12.1 profile the test now expects did not match the package. Generate both live fixtures at typedb-3.12.1/v1 for the 3.12.3 service, and format the updated inventory tests. Parts of #253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2.3.0 candidate run (39381210933) on the 2.3 merge failed five acceptance jobs. Two causes, both specific to 2.3 and invisible to CI:
cargo metadataresolves optional path dependencies, and the bindings' optionaltype-bridge-perfwas not in the sdist. Including it would drag in the Rust SDK, the CLI and their dev-dependency graph through itspipelinesfeature. Failed: Python release artifacts on 3.12, 3.13.5 and 3.14.typedb-3.13.6/v1; the release acceptance service is TypeDB 3.12.3. Failed: generated live artifact parity, and the server OCI's external Rust application.Changes
type-bridge-perf-stagesholds the stage layer (it needs onlytracing).type-bridge-perfre-exports it asstages; the Python, Node and C bindings' off-by-defaultperf-stagesfeature links the leaf crate.crates/perf-stagesas an explicit raw source root, likeorm-derive. The sdist validator, the Cargo release inventory and their tests name the new crate; C distribution and ledger digests rebound for the changed C manifest.release.yml: the exact-wheel Python application and the external Rust application selecttypedb-3.12.1/v1, as CI does for its 3.12.3 lanes.Verification
crates/perf-stagesand passescargo metadata --offlinefrom the unpacked archive.cargo clippy -p type-bridge-perf-stages -p type-bridge-perf --all-targets -D warnings; perf-stages tests;cargo checkof type-bridge-core, type-bridge-node and type-bridge-c withperf-stages.pytest tests/unit/infra tests/unit/compat tests/unit/perf: 1732 passed. Native notice check passes; actionlint clean.Parts of #253