Repository navigation
Fix: Enforce exact 10_000 basis points for custom payout curve weights - #324
Merged
dultimateade merged 1 commit intoOct 21, 2026
Merged
Conversation
Fixes a critical vulnerability where custom weight validation allowed sums between 1 and 9,999 basis points, enabling market creators to lock user funds permanently by allocating less than 100% of the pool. Changes: - validate_payout_curve now requires sum == 10_000 (exact 100% allocation) - Prevents partial pool allocations that would leave funds unclaimable - Old check (sum == 0 || sum > 10_000) allowed 9_999 to pass; now rejects Testing: - Added test_custom_weights_exactly_10000_required to verify: * Rejects weights summing to 9_999 (0.01% under) * Rejects weights summing to 5_000 (50% of pool) * Rejects weights summing to 1 * Accepts weights summing to exactly 10_000
|
@pearlsslove Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #181
closes #187
Fixes a critical vulnerability where custom weight validation allowed sums between 1 and 9,999 basis points, enabling market creators to lock user funds permanently by allocating less than 100% of the pool.
Changes:
Testing: