Repository navigation
fix(analytics): Add authentication to record_metric functions - #325
Merged
dultimateade merged 2 commits intoOct 22, 2026
Merged
dultimateade merged 2 commits into
dultimateade merged 2 commits into
Conversation
Fixes critical vulnerability where record_metric and record_metric_at allowed any account to write arbitrary metrics. Implements whitelist-based authorization with admin-controlled reporters. Changes: - Add initialize() function with admin setup - Add add/remove_authorized_reporter() for reporter management - Protect record_metric() with authorization check - Protect record_metric_at() with authorization check and require_auth() - Add is_authorized_reporter() query function - Prevent duplicate metric entries - Add comprehensive auth boundary tests (24 test cases) Security properties: - Only whitelisted reporters can record metrics - Admin-controlled reporter whitelist - Immutable audit trail (metrics cannot be modified) - Duplicate prevention - Soroban require_auth() enforcement Documentation: - ANALYTICS_AUTH_FIX.md: Detailed fix explanation and integration guide - ANALYTICS_FIX_VERIFICATION.md: Complete security verification Impact: HIGH - Closes data integrity vulnerability
|
@swantaafuwai-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #180
closes #184
closes #183
closes #178
Fixes critical vulnerability where record_metric and record_metric_at allowed any account to write arbitrary metrics. Implements whitelist-based authorization with admin-controlled reporters.
Changes:
Security properties:
Documentation:
Impact: HIGH - Closes data integrity vulnerability