Skip to content

Fix migrate contract initialization #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dultimateade merged 1 commit into from
Oct 21, 2026
Merged

Fix migrate contract initialization #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions contracts/migrate/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
#![no_std]

use soroban_sdk::{contract, contractimpl, contracttype, contracterror, Address, Env, Symbol, Vec, Map, BytesN};

mod migrate;

use soroban_sdk::{
contract, contracterror, contractevent, contractimpl, contracttype, Address, Env,
contract, contracterror, contractimpl, contracttype, Address, BytesN, Env, Map, Symbol, Vec,
};

mod migrate;

#[contracttype]
#[derive(Clone)]
pub enum DataKey {
Expand Down Expand Up @@ -36,13 +34,6 @@ pub enum ContractError {
MigrationFailed = 7,
}

/// Storage version key
const VERSION_KEY: Symbol = Symbol::new("VERSION");
/// Admin key
const ADMIN_KEY: Symbol = Symbol::new("ADMIN");
/// Migration data prefix
const MIGRATION_PREFIX: Symbol = Symbol::new("MIGRATION_");

/// Migration metadata stored per version upgrade
#[contracttype]
#[derive(Clone, Debug, Eq, PartialEq)]
Expand Down Expand Up @@ -90,10 +81,12 @@ impl MigrateContract {
return Err(ContractError::InvalidTargetVersion);
}

if env.storage().instance().has(&VERSION_KEY) {
if env.storage().instance().has(&DataKey::Version) {
return Err(ContractError::AlreadyInitialized);
}
.publish(&env);

env.storage().instance().set(&DataKey::Admin, &admin);
env.storage().instance().set(&DataKey::Version, &version);
Ok(())
}

Expand Down
Loading