Use threading to further decrease benchmark running time.#24
Open
abeaumont wants to merge 1 commit into
Open
Conversation
housel
approved these changes
Aug 27, 2019
cgay
reviewed
Aug 27, 2019
| for (thread in threads) | ||
| thread & join-thread(thread); | ||
| end; | ||
| for (message in messages) |
Member
There was a problem hiding this comment.
Is the order of the output important for their benchmark harness? If so, I guess you could put pair(i, msg) into messages and sort by i.
Member
Author
There was a problem hiding this comment.
Yes, I assume the output order is important, but messages are already sorted through their indices (each task stores the result in the i-th message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.