Skip to content

Test battery ID selection - #19

Closed
dymk wants to merge 4 commits into
mainfrom
dymk/battery-id-e2e
Closed

dymk wants to merge 4 commits into
mainfrom
dymk/battery-id-e2e

Conversation

@dymk

@dymk dymk commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • register distinct 3S and 2S batteries in the dev-QEMU EC fixture
  • stack the secure-services Battery payload-dispatch fix
  • verify battery IDs 0 and 1 return their respective pack voltages through the two-QEMU relay E2E

Stack

  1. Add second mock battery odp-embedded-controller#7
  2. Fix Battery FF-A request payload dispatch odp-secure-services#12
  3. This PR

The submodule URLs intentionally point to the fork commits while this stack is under review. Restore them to OpenDevicePartnership URLs after the dependency PRs land upstream.

Validation

  • ./.husky/pre-commit
  • make -C e2e-tests relay-run-battery SERIAL_TEE=1

Battery 0 returns 11850 mV; battery 1 returns 7900 mV.

dymk added 4 commits July 29, 2026 19:08
Stack the request-driven Battery handler with two distinct dev-QEMU fuel gauges so the relay E2E proves that battery IDs select different packs.

Assisted-by: GitHub Copilot:gpt-5.6-sol

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
Advance the embedded-controller stack to include battery IDs in per-gauge error logs requested during review.

Assisted-by: GitHub Copilot:gpt-5.6-sol

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
Advance the embedded-controller stack to the platform-common formatting fix required by CI.

Assisted-by: GitHub Copilot:gpt-5.6-sol

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
Replace the temporary fork pins with the merged upstream EC and secure-services commits so the E2E stack is ready for upstream review.

Assisted-by: GitHub Copilot:gpt-5.6-sol

Copilot-Session: a3539bc8-3a1f-44b3-ba4a-c171a7822595
@dymk
dymk force-pushed the dymk/battery-id-e2e branch from 9f5d84e to 7994c1e Compare July 29, 2026 19:14
@dymk

dymk commented Jul 29, 2026

Copy link
Copy Markdown
Owner Author

Merged upstream as OpenDevicePartnership#138.

@dymk dymk closed this Jul 29, 2026
@dymk
dymk deleted the dymk/battery-id-e2e branch July 30, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant