Rebase integration test patches for rhel9.7 - #1482
Merged
Merged
Conversation
joe-lawrence
requested changes
Oct 28, 2025
joe-lawrence
left a comment
Contributor
There was a problem hiding this comment.
Hi @Tomcat-42 -- the integration patches and tests look fine to me. A small nitpick, can you update the commit message like so:
test/integration/rhel-9.7: add kernel-5.14.0-<kver>.el9 tests
Signed-off-by: Your name <your@email.com>
That way we know precisely which kernel source this was based on and signed-off-by line.
Signed-off-by: Pablo Alessandro Santos Hugen <phugen@redhat.com>
Tomcat-42
force-pushed
the
integration-rhel9.7
branch
from
October 28, 2025 23:45
108e088 to
5e272ad
Compare
Signed-off-by: Pablo Alessandro Santos Hugen <phugen@redhat.com>
Tomcat-42
force-pushed
the
integration-rhel9.7
branch
from
October 28, 2025 23:48
5e272ad to
1cae608
Compare
Contributor
Author
|
Hi @joe-lawrence, thanks for the suggestions. I've updated the messages |
Contributor
Author
|
Hi @joe-lawrence, the ppc64le integration-upstream failed: But it's because I've recently merged https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/commit/39f947a7d9fb5af39dbc824d5536ea76daae8a13. So I'm pretty sure We're fine on this |
joe-lawrence
approved these changes
Oct 30, 2025
Contributor
|
Thanks, @Tomcat-42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.