Skip to content

Cover Image and Encoding bug fixes - #21

Open
filiptrplan wants to merge 6 commits into
e1miran:masterfrom
filiptrplan:cover-image
Open

Cover Image and Encoding bug fixes#21
filiptrplan wants to merge 6 commits into
e1miran:masterfrom
filiptrplan:cover-image

Conversation

@filiptrplan

@filiptrplan filiptrplan commented Feb 11, 2021

Copy link
Copy Markdown

I decided to add the functionality to write a cover image beside the track information file.

Also, the encoding of the parser was wrong so I fixed that, though it is only a temporary fix. It should be utf-16-be and not latin but then it throws some errors. I would suggest just manipulating the raw bytes and decoding only when necessary. Now it also handles stuff like č, ž and Chinese characters properly.

I also added a gitignore because some people use pipenv.

Also, I added some missing packages to requirements.txt.

I know these things should be separate pull requests but I couldn't be bothered.

P.S. The code is very messy when you put everything into one file. I would suggest breaking it up before it becomes too massive.

@e1miran

e1miran commented Feb 11, 2021

Copy link
Copy Markdown
Owner

@1234filip Thanks for the contribution. Two separate pull requests for the encoding issues and the cover art feature would be appreciated as I'm not inclined to merge these changes to the main branch together. Especially in the case of the cover art feature, which would require time for updating the read.me and familiarity with in order to provide support.

@filiptrplan

Copy link
Copy Markdown
Author

@1234filip Thanks for the contribution. Two separate pull requests for the encoding issues and the cover art feature would be appreciated as I'm not inclined to merge these changes to the main branch together. Especially in the case of the cover art feature, which would require time for updating the read.me and familiarity with in order to provide support.

I'll make a separate request for the encoding issue but I can't decouple them as the cover art feature isn't possible without the encoding one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants