Allow using ec.dependency_names inside parse_hook#5176
Open
Flamefire wants to merge 2 commits into
Open
Conversation
Flamefire
force-pushed
the
parse-hook-dep-names
branch
from
1497a86 to
d05fafd
Compare
This is useful to avoid boilerplate when checking for existance of a specific dependency. Even though the dependency might be filtered out later it is better than nothing.
It wrongly depended on a toolchain module despite the name.
Flamefire
force-pushed
the
parse-hook-dep-names
branch
from
d05fafd to
ec613e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to avoid boilerplate when checking for existance of a specific dependency. Even though the dependency might be filtered out later it is better than nothing.