Remove repetition of shell command in log#5195
Open
Flamefire wants to merge 2 commits into
Open
Conversation
Flamefire
force-pushed
the
shell-cmd-output-shorting
branch
from
81c1661 to
73bac61
Compare
Only mention the command once to avoid cluttering the log. Also moves the command around, i.e. not "foo shell command" but "shell command foo" Result: > == 2026-06-11 10:59:59,270 run.py:486 INFO run_shell_cmd: Script to start debug shell for shell command 'echo ...' > will be saved to /tmp/eb-a0hz36a8/eb-481rmksq/eb-8t3f24id/eb-ncfim2n4/run-shell-cmd-output/echo-c03bkciy/cmd.sh > output will be logged to /tmp/eb-a0hz36a8/eb-481rmksq/eb-8t3f24id/eb-ncfim2n4/run-shell-cmd-output/echo-c03bkciy/out.txt > == 2026-06-11 10:59:59,271 run.py:512 INFO Path to bash that will be used to run shell commands: /usr/bin/bash > == 2026-06-11 10:59:59,271 run.py:526 INFO Running shell command in /home/alex/git/easybuild-framework: > echo hello > == 2026-06-11 10:59:59,276 run.py:645 INFO Shell command 'echo ...' completed successfully > Output (stdout + stderr): > hello > >
The cmd does not need to be mentioned when it directly follows the full command: > == 2026-06-11 11:15:57,014 run.py:486 INFO run_shell_cmd: Script to start debug shell for shell command 'echo ...' > will be saved to /tmp/eb-sqv44xur/eb-jt25_0o7/eb-8cg0xkof/eb-tbmdi883/run-shell-cmd-output/echo-_nwcdoh_/cmd.sh > output will be logged to /tmp/eb-sqv44xur/eb-jt25_0o7/eb-8cg0xkof/eb-tbmdi883/run-shell-cmd-output/echo-_nwcdoh_/out.txt > == 2026-06-11 11:15:57,015 run.py:512 INFO Path to bash that will be used to run shell commands: /usr/bin/bash > == 2026-06-11 11:15:57,015 run.py:526 INFO Running shell command in /home/alex/git/easybuild-framework: > echo hello > == 2026-06-11 11:16:04,875 run.py:645 INFO Shell command completed successfully > Output (stdout + stderr): > hello
Flamefire
force-pushed
the
shell-cmd-output-shorting
branch
from
73bac61 to
1eeefde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only mention the command once to avoid cluttering the log. Also moves the command around, i.e. not "foo shell command" but "shell command foo"
Result:
This allows to find it more easily by grepping for e.g. "Running shell command" and avoids repeating the same command multiple times which makes it harder to find the actual command