Repository navigation
Configure BaSyx Go ReBAC in the access control step - #42
Merged
Merged
Conversation
- Add an optional ReBAC section that writes REBAC_ENABLED, REBAC_SUBJECT_CLAIM, REBAC_GROUP_CLAIM and REBAC_ADMINISTRATORS, and removes them when ReBAC or access control is disabled. - Validate administrator entries (issuer|subject or issuer|group:<name>). - Add a groups claim mapper and a basyx-admins group containing basyx-admin to the local Keycloak realm; default the administrators to that group. - Allow /description publicly in the starting policy so clients can detect ReBAC. - Show ReBAC in the security summary and the generated README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aaronzi
commented
Sep 28, 2026
aaronzi
left a comment
aaronzi
left a comment
Member
Author
There was a problem hiding this comment.
Found two configuration issues, detailed inline. Validation: all 116 tests and type checking passed; both findings were reproduced with focused checks. Full Docker startup was not tested.
- Split administrator entries only at the first "|", like BaSyx Go, so subjects such as auth0|123 are accepted. - Move an untouched generated administrator default to the new issuer when the issuer or identity provider changes; keep edited lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow generated BaSyx setups to enable the experimental relationship-based access control (ReBAC) of BaSyx Go 1.1.0.
The Access Control step gets a Resource sharing (ReBAC) section, available when access control is enabled. It writes
REBAC_ENABLED,REBAC_SUBJECT_CLAIM,REBAC_GROUP_CLAIMandREBAC_ADMINISTRATORSto the AAS Environment. Administrators are validated asissuer|subjectorissuer|group:<name>. Disabling ReBAC or access control removes all four variables, because BaSyx Go refuses to start ReBAC without ABAC. The security summary shows the ReBAC state.ReBAC works with the local Keycloak without further setup:
groupsclaim mapper (full path off) and abasyx-adminsgroup that containsbasyx-admin.<issuer>|group:basyx-admins, and the generated README explains the group.The starting access policy now allows
GET /descriptionfor everyone. The BaSyx Web UI uses the service description to detect ReBAC. The endpoint only exposes the service profiles.Eventing, the Event Feed and
GENERAL_DELEGATEDOPERATIONRESPONSEMAXSIZEBYTESare already configurable, so ReBAC was the only missing BaSyx Go 1.1.0 setting.Related:
Validation:
pnpm format:checkpnpm lint:check(0 errors; 11 existing warnings in untouched files)pnpm typecheckpnpm test(23 files, 116 tests)pnpm buildgit diff --checkTests cover the ReBAC environment, removing it when ReBAC or access control is turned off, administrator validation, the public description rule, and the realm group and mapper.
🤖 Generated with Claude Code