Skip to content

[Test] Fix up 'factory' E2E tests when use public repository - #23617

Merged
artaleks9 merged 22 commits into
mainfrom
che#22597
Oct 29, 2025
Merged

[Test] Fix up 'factory' E2E tests when use public repository#23617
artaleks9 merged 22 commits into
mainfrom
che#22597

Conversation

@artaleks9

@artaleks9 artaleks9 commented Oct 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes NoSetupRepoFactory E2E test by finishing on Commit the changes test step, as a successful and remove unnecessary steps, like Push the changes.
  • Fixes RefusedOAuthFactory.spec.ts E2E test by finishing on Commit the changes test step, as a successful and remove unnecessary steps, like Push the changes.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#22597

How to test this PR?

Run usually NoSetupRepoFactory and RefusedOAuthFactory E2E tests

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@artaleks9 artaleks9 self-assigned this Oct 14, 2025
@artaleks9
artaleks9 requested review from SkorikSergey and removed request for musienko-maxim October 14, 2025 07:47
dmytro-ndp
dmytro-ndp reviewed Oct 20, 2025
View reviewed changes
Comment thread tests/e2e/constants/FACTORY_TEST_CONSTANTS.ts Resolved
dmytro-ndp
dmytro-ndp reviewed Oct 28, 2025
View reviewed changes
Comment thread tests/e2e/specs/factory/Factory.spec.ts Resolved
dmytro-ndp
dmytro-ndp approved these changes Oct 29, 2025
View reviewed changes

@dmytro-ndp dmytro-ndp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good to merge after resolving merge conflicts.

Well done, @artaleks9 !

@artaleks9
artaleks9 merged commit da36bbf into main Oct 29, 2025
6 checks passed
@artaleks9
artaleks9 deleted the che#22597 branch October 29, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes
+1 more reviewer
@SkorikSergey SkorikSergey SkorikSergey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artaleks9 artaleks9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artaleks9 @dmytro-ndp @SkorikSergey