[SkorikSergey]

What does this PR do?

Automate "SSH key with passphrase configuration from the User Dashboard" test-case

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-5392

How to test this PR?

To test this PR:

• set TS_SELENIUM_SSH_PRIVATE_KEY and TS_SELENIUM_SSH_PUBLIC_KEY
• also passphrase by TS_SELENIUM_SSH_PASSPHRASE
• set TS_SELENIUM_FACTORY_GIT_REPO_URL for repo url
• start SshUrlNoOauthPatFactory e2e test

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix or new feature
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

ssh.txt
ssh_bitbucket.txt
ssh_with_passphrase.txt

[dmytro-ndp]

Correct name is TS_SELENIUM_SSH_KEY_PASSPHRASE.

[dmytro-ndp]

it would better to say "ssh key passphrase" to avoid confusion

[dmytro-ndp]

correct name is TS_SELENIUM_SSH_KEY_PASSPHRASE

[dmytro-ndp]

@SkorikSergey: thank you for test automation!

It's also important to ensure in the test that push inside the workspace without personal access token using either terminal or source control view works without asking for the passphrase.
There was a problem with it in the past: eclipse-che/che-dashboard#1157 (comment)

See an example of push verification in the test https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/factory/NoSetupRepoFactory.spec.ts#L192-L251

[dmytro-ndp]

@SkorikSergey: thank you for pointing out the fact that SshUrlNoOauthPatFactory will fail if adding https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/factory/NoSetupRepoFactory.spec.ts#L140-L154 steps into it without adding Data.txt file to the test repo:

• https://gh.crw-qe.com/test-automation-only/quarkus-api-example.git
• bitbucket-ssh.apps.ds-airgap2-v15.crw-qe.com/~admin/private-bb-repo.git

Please add Data.txt file to those repos as well.

[dmytro-ndp]

@SkorikSergey : thank you for the test improvement! The changes commonly look good.
Do you have new test results to review?

[artaleks9]

The code looks good.
Yes, interesting to see results of run the test with the last changes.

[SkorikSergey]

@SkorikSergey : thank you for the test improvement! The changes commonly look good. Do you have new test results to review?

Added 3 text files with test result. Two for github repository and bitbucket(default for this test).

[dmytro-ndp]

@SkorikSergey : thank you for sharing the test run logs.

I found a commit message mismatch in the logs and repo.
In repo there is no "Commit" prefix in the commit message, while ssh_with_passphrase.txt log contains it:

▼ SourceControlView.typeCommitMessage - Type commit text: "Commit 1765382240250"

Could you please take a look?

[SkorikSergey]

@SkorikSergey : thank you for sharing the test run logs.

I found a commit message mismatch in the logs and repo. In repo there is no "Commit" prefix in the commit message, while ssh_with_passphrase.txt log contains it:

▼ SourceControlView.typeCommitMessage - Type commit text: "Commit 1765382240250"

Could you please take a look?

Thank you for attention. Commit prefix really not exist in commit message in this test and NoSetupRepoFactory for which I copy-pasted :). I will add prefix to message.

[dmytro-ndp]

PR looks good to merge, IMHO

@SkorikSergey : thank you for test automation!