Skip to content

Handle UnexpectedAlertOpenError in RestartFromLocalDevlile. #23953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
olkornii wants to merge 1 commit into
base: main
Choose a base branch
from
+43 −3
Draft

Handle UnexpectedAlertOpenError in RestartFromLocalDevlile. #23953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 43 additions & 3 deletions tests/e2e/specs/restart-tests/RestartFromLocalDevfile.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { BrowserTabsUtil } from '../../utils/BrowserTabsUtil';
import { DriverHelper } from '../../utils/DriverHelper';
import { ProjectAndFileTests } from '../../tests-library/ProjectAndFileTests';
import { RestartWorkspaceDialog } from '../../pageobjects/ide/RestartWorkspaceDialog';
import { By } from 'selenium-webdriver';
import { By, error } from 'selenium-webdriver';
import { registerRunningWorkspace } from '../MochaHooks';

suite(`Test case with empty workspace (per-user storage) ${BASE_TEST_CONSTANTS.TEST_ENVIRONMENT}`, function (): void {
Expand Down Expand Up @@ -112,8 +112,28 @@ suite(`Test case with empty workspace (per-user storage) ${BASE_TEST_CONSTANTS.T

test('Restart workspace from local devfile with bad image', async function (): Promise<void> {
await restartWorkspaceDialog.restartFromLocalDevfile(projectName);

Logger.info('Waiting for "Restart Workspace" confirmation popup');
await restartWorkspaceDialog.confirmRestartWorkspace();
try {
await restartWorkspaceDialog.confirmRestartWorkspace();
} catch (err) {
if (err instanceof error.UnexpectedAlertOpenError) {
let alertText: string = '';
try {
alertText = await driverHelper.getDriver().switchTo().alert().getText();
} catch (alertErr) {
// alert already auto-dismissed by Chrome
}
if (alertText === '') {
Logger.info('UnexpectedAlertOpenError with empty text caught, retrying confirmRestartWorkspace');
await restartWorkspaceDialog.confirmRestartWorkspace();
} else {
throw new error.UnexpectedAlertOpenError(`unexpected alert with text: "${alertText}"`);
}
} else {
throw err;
}
}
});

test('Wait for workspace start failure and restart', async function (): Promise<void> {
Expand Down Expand Up @@ -281,8 +301,28 @@ suite(`Test case with pvc-fail workspace (bad image restart) ${BASE_TEST_CONSTAN

test('Restart workspace from local devfile with bad image', async function (): Promise<void> {
await restartWorkspaceDialog.restartFromLocalDevfile(projectName);

Logger.info('Waiting for "Restart Workspace" confirmation popup');
await restartWorkspaceDialog.confirmRestartWorkspace();
try {
await restartWorkspaceDialog.confirmRestartWorkspace();
} catch (err) {
if (err instanceof error.UnexpectedAlertOpenError) {
let alertText: string = '';
try {
alertText = await driverHelper.getDriver().switchTo().alert().getText();
} catch (alertErr) {
// alert already auto-dismissed by Chrome
}
if (alertText === '') {
Logger.info('UnexpectedAlertOpenError with empty text caught, retrying confirmRestartWorkspace');
await restartWorkspaceDialog.confirmRestartWorkspace();
} else {
throw new error.UnexpectedAlertOpenError(`unexpected alert with text: "${alertText}"`);
}
} else {
throw err;
}
}
});

test('Wait for workspace start failure and restart with default devfile', async function (): Promise<void> {
Expand Down
Loading