Skip to content

Update jdt.ui's main README#1707

Open
HannesWell wants to merge 1 commit into
eclipse-jdt:masterfrom
HannesWell:update-readme
Open

Update jdt.ui's main README#1707
HannesWell wants to merge 1 commit into
eclipse-jdt:masterfrom
HannesWell:update-readme

Conversation

@HannesWell

Copy link
Copy Markdown
Contributor

What it does

Update links, remove obsolete sections and use simpler markdown style, similar to jdt.core's README.

Author checklist

Comment thread README.md

Contributor License Agreement:
------------------------------
- https://eclipse.dev/jdt/ui/index.php#dev

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the announced deprecation of php-content on eclipse.dev websites I assume this link will not work well for a long time, but at the moment there is nothing better I know.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should point to the php page. It is out of date and points to other out of date pages. I would suggest you either leave the link above (which is archived) or create a new .md file by stealing any relevant text from the php page you pointed to, replacing or simply removing any php links. This at least gives a base for building on.

Comment thread CONTRIBUTING
@jukzi jukzi requested a review from jjohnstn October 10, 2024 14:22
@HannesWell HannesWell force-pushed the update-readme branch 2 times, most recently from a053f31 to 4a1eac2 Compare October 14, 2024 20:34
@HannesWell

Copy link
Copy Markdown
Contributor Author

@jjohnstn can you please review this?

@jjohnstn

Copy link
Copy Markdown
Contributor

@HannesWell @jukzi I was on vacation. Will do.

Comment thread README.md

Contributor License Agreement:
------------------------------
- https://eclipse.dev/jdt/ui/index.php#dev

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should point to the php page. It is out of date and points to other out of date pages. I would suggest you either leave the link above (which is archived) or create a new .md file by stealing any relevant text from the php page you pointed to, replacing or simply removing any php links. This at least gives a base for building on.

Comment thread README.md

Contributor License Agreement:
------------------------------
- https://eclipse.dev/jdt/ui/index.php#dev

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is still a link to the php page :-(

Comment thread CONTRIBUTING
Contact the project developers via the project's "dev" list.

* https://dev.eclipse.org/mailman/listinfo/jdt-dev No newline at end of file
See https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need that file at all, when it contains a link only? better just delete it?

Update links, remove obsolete sections and use simpler markdown style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants