Filter top menu#1731
Draft
jannisCode wants to merge 1 commit into
Draft
Conversation
jannisCode
force-pushed
the
filter_top_Menu
branch
3 times, most recently
from
50fe9eb to
4b7d072
Compare
jannisCode
added a commit
to jannisCode/eclipse.jdt.ui
that referenced
this pull request
Oct 23, 2024
The filter button in the Call Hierarchy now has the option to expand a menu where one can switch between the filters eclipse-jdt#1731
jannisCode
force-pushed
the
filter_top_Menu
branch
from
4b7d072 to
095baa3
Compare
fedejeanne
suggested changes
Oct 29, 2024
fedejeanne
left a comment
fedejeanne
left a comment
Contributor
There was a problem hiding this comment.
Check indentation of added/modified code, check the headers of added files (one is wrong), remove commented code.
You may delay working on this until #1730 is merged.
Contributor
Author
|
That´s the plan (to wait). I just wanted to show why #1730 is important by showing what this PR will do |
The filter button in the Call Hierarchy now has the option to expand a menu where one can switch between the filters eclipse-jdt#1731
jannisCode
force-pushed
the
filter_top_Menu
branch
from
095baa3 to
daa1742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This PR changes the Button which was added to the top bar #1671 to a drop-down-menu like the history.
When clicking the filter icon, it opens a Filters Dialog, just like normal, when clicking on the arrow, a new Menu opens in which one can change the filters.
When hovering over the filters icon, a tooltip tells you which filter is currentliy active
Important
If #1730 is a change worth considering, and will be merged, the code from this PR has to be adapted to the new, more adaptable code from #1730. If that is the case, please let me know, then I can change it.
Author checklist