Skip to content

Fix Package Explorer View filter not filtering non-archive plug-ins part 2 #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohnstn merged 1 commit into from
Jun 22, 2026
Merged

Fix Package Explorer View filter not filtering non-archive plug-ins part 2 #3041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/filters/ContainedLibraryFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,13 @@ public class ContainedLibraryFilter extends ViewerFilter {

@Override
public boolean select(Viewer viewer, Object parentElement, Object element) {
if (element instanceof IPackageFragmentRoot) {
IPackageFragmentRoot root= (IPackageFragmentRoot)element;
if (root.isArchive()) {
// don't filter out JARs contained in the project itself
IResource resource= root.getResource();
if (resource != null) {
IProject jarProject= resource.getProject();
IProject container= root.getJavaProject().getProject();
return !container.equals(jarProject);
}
if (element instanceof IPackageFragmentRoot root) {
// don't filter out libraries contained in the project itself
IResource resource= root.getResource();
if (resource != null) {
IProject project= resource.getProject();
IProject container= root.getJavaProject().getProject();
return !container.equals(project);
}
}
return true;
Expand Down
Loading