Skip to content

Create Maven nested project Test Case - Reproduce the Issue ".java is not on the classpath of project" #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnqiHuangQiQi wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Create Maven nested project Test Case - Reproduce the Issue ".java is not on the classpath of project" #3460

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
79ed27d
Create nested project
AnqiHuangQiQi Jun 2, 2025
3681a21
Add more files
AnqiHuangQiQi Jun 2, 2025
9fdfe21
Create .classpath
AnqiHuangQiQi Jun 2, 2025
d5c64a4
Add files via upload
AnqiHuangQiQi Jun 2, 2025
d13a3ca
Create .project
AnqiHuangQiQi Jun 2, 2025
8671056
Update and rename pom.xml to .project
AnqiHuangQiQi Jun 2, 2025
f24ab5f
Create .classpath
AnqiHuangQiQi Jun 2, 2025
513194d
Delete mypackage_mytarget/pom.xml
AnqiHuangQiQi Jun 2, 2025
5ca6eef
Fix
AnqiHuangQiQi Jun 10, 2025
2eedeae
Update JDTUtils.java
AnqiHuangQiQi Jun 10, 2025
1fa97f1
update linkedResource path
AnqiHuangQiQi Jun 10, 2025
4bbf792
Update JDTUtils indent
AnqiHuangQiQi Jun 10, 2025
16f011f
Update .project
AnqiHuangQiQi Jun 10, 2025
f1dd774
Merge branch 'eclipse-jdtls:main' into patch-1
AnqiHuangQiQi Jun 25, 2025
aeb389f
fix JdtUtils FindResource
AnqiHuangQiQi Jun 23, 2025
5b02a1e
verify if compilation unit path match with packagefragmentroot path
AnqiHuangQiQi Jun 24, 2025
c249465
remove unnecessary conflict
AnqiHuangQiQi Jun 25, 2025
69e790d
fix the merge conflicts which removed the original code
AnqiHuangQiQi Jun 26, 2025
e120794
address comments
AnqiHuangQiQi Jun 27, 2025
e15c9f6
Merge branch 'eclipse-jdtls:main' into patch-1
AnqiHuangQiQi Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
import java.nio.file.InvalidPathException;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Arrays;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
Expand Down Expand Up @@ -70,6 +72,8 @@
import org.eclipse.jdt.core.IMethod;
import org.eclipse.jdt.core.IOpenable;
import org.eclipse.jdt.core.IPackageFragment;
import org.eclipse.jdt.core.IPackageFragmentRoot;
import org.eclipse.jdt.core.IPackageFragmentRoot;
import org.eclipse.jdt.core.ISourceRange;
import org.eclipse.jdt.core.ISourceReference;
import org.eclipse.jdt.core.IType;
Expand Down Expand Up @@ -117,6 +121,8 @@
import org.eclipse.jdt.internal.compiler.lookup.Binding;
import org.eclipse.jdt.internal.compiler.lookup.MethodBinding;
import org.eclipse.jdt.internal.core.NamedMember;
import org.eclipse.jdt.internal.core.PackageFragmentRoot;
import org.eclipse.jdt.internal.core.PackageFragmentRoot;
import org.eclipse.jdt.internal.core.manipulation.JavaElementLabelComposerCore;
import org.eclipse.jdt.internal.core.manipulation.JavaElementLabelsCore;
import org.eclipse.jdt.internal.core.manipulation.search.IOccurrencesFinder.OccurrenceLocation;
Expand Down Expand Up @@ -1182,6 +1188,8 @@ public static IResource findResource(URI uri, Function<URI, IResource[]> resourc
JavaLanguageServerPlugin.logException(e.getMessage(), e);
}
}

//find the resource which has PackageFragmentRoot
//find closest project containing that file, in case of nested projects

@guw guw Jun 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//find the resource which has PackageFragmentRoot
//find closest project containing that file, in case of nested projects
//find closest project containing that file, in case of nested projects
//ignore files outside a source folder (https://github.com/eclipse-jdtls/eclipse.jdt.ls/issues/3447)

@guw guw Jun 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the method name findResource no longer matches the contract now. This should be addressed.

if (resource == null || f.getProjectRelativePath().segmentCount() < resource.getProjectRelativePath().segmentCount()) {
resource = f;
Expand All @@ -1191,6 +1199,26 @@ public static IResource findResource(URI uri, Function<URI, IResource[]> resourc
}
}

private static boolean hasPackageFragmentRoot(IResource resource) {
ICompilationUnit unit = resolveCompilationUnit((IFile)resource);
if (unit == null || unit.getJavaProject() == null) {
return false;
}
try {;
IPath path = unit.getPath();

IPackageFragmentRoot[] packageFragmentRoots = unit.getJavaProject().getPackageFragmentRoots();
boolean containsPackageFragmentRoot = Arrays.stream(packageFragmentRoots)
.anyMatch(root -> root.getClass().equals(PackageFragmentRoot.class)

@guw guw Jun 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd. Don't use getClass().equals(..). Use isInstance. Don't use internal classes (eg., PackageFragmentRoot). Use official JDT API only. Also, this check is unnecessary. The array is already IPackageFragmentRoot

&& packageFragmentRoots[0].getPath().isPrefixOf(path));

return containsPackageFragmentRoot;
} catch (JavaModelException e) {
JavaLanguageServerPlugin.log(e);
return false;
}
}

public static URI toURI(String uriString) {
if (uriString == null || uriString.isEmpty()) {
return null;
Expand Down
5 changes: 5 additions & 0 deletions org.eclipse.jdt.ls.tests/projects/maven/nested-project/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
<classpathentry kind="output" path="eclipse-bin"/>
</classpath>
6 changes: 6 additions & 0 deletions ...dt.ls.tests/projects/maven/nested-project/.eclipse/projects/mypackage_mytarget/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" path="linked-srcs" />
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
<classpathentry kind="output" path="eclipse-bin"/>
</classpath>
41 changes: 41 additions & 0 deletions ....jdt.ls.tests/projects/maven/nested-project/.eclipse/projects/mypackage_mytarget/.project
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>mypackage_mytarget</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
<buildCommand>
<name>org.eclipse.jdt.core.javabuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.m2e.core.maven2Nature</nature>
<nature>org.eclipse.jdt.core.javanature</nature>
</natures>
<linkedResources>
<link>
<name>linked-srcs/com/packages/foo/File.java</name>
<type>1</type>
<location>PARENT-3-PROJECT_LOC/com/packages/foo/File.java</location>
</link>
</linkedResources>
<filteredResources>
<filter>
<id>1748456351890</id>
<name></name>
<type>30</type>
<matcher>
<id>org.eclipse.core.resources.regexFilterMatcher</id>
<arguments>node_modules|\.git|__CREATED_BY_JAVA_LANGUAGE_SERVER__</arguments>
</matcher>
</filter>
</filteredResources>
</projectDescription>
Binary file added ...sted-project/.eclipse/projects/mypackage_mytarget/eclipse-bin/com/packages/foo/File.class
View file
Open in desktop
Binary file not shown.
34 changes: 34 additions & 0 deletions org.eclipse.jdt.ls.tests/projects/maven/nested-project/.project
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>workspace_root</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
<buildCommand>
<name>org.eclipse.jdt.core.javabuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.m2e.core.maven2Nature</nature>
<nature>org.eclipse.jdt.core.javanature</nature>
</natures>
<filteredResources>
<filter>
<id>1748456351890</id>
<name></name>
<type>30</type>
<matcher>
<id>org.eclipse.core.resources.regexFilterMatcher</id>
<arguments>node_modules|\.git|__CREATED_BY_JAVA_LANGUAGE_SERVER__</arguments>
</matcher>
</filter>
</filteredResources>
</projectDescription>
9 changes: 9 additions & 0 deletions org.eclipse.jdt.ls.tests/projects/maven/nested-project/com/packages/foo/File.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.packages.foo;

public class File
{
public static void main(String[] args)
{
System.out.println("Hello, World");
}
}