Fix Scala Gradle classpath pollution

[wenytang-ms]

Limit Scala Gradle classpath augmentation to Scala projects and avoid adding Gradle project dependency artifacts as raw build/libs entries.

Also keeps Gradle resources visible on the classpath and adds a multi-project Scala Gradle fixture covering project dependencies, resources, and Java-to-Scala references.

Supersedes #3776.

Related issues:

• Gradle multi-project import materializes internal build/libs jars into live JDT classpath redhat-developer/vscode-java#4399
• Resources (application.properties) automatically deleted from bin folder shortly after generation in Gradle project redhat-developer/vscode-java#4398
• src/main/resources excluded from classpath for Gradle subprojects with generated source directories redhat-developer/vscode-java#4393

[wenytang-ms]

@datho7561 I have create a new PR and close the original one, can you share why the Jenkinds build failed because I don't have account to see the running error.

[jjohnstn]

The failure was for SyntaxServerTest: It fails for me without your patch.

Error Details

expected: <Syntax error, insert ";" to complete FieldDeclaration> but was: <Either [
left = Syntax error, insert ";" to complete FieldDeclaration
right = null
]>

Stack Trace

org.opentest4j.AssertionFailedError:
expected: <Syntax error, insert ";" to complete FieldDeclaration> but was: <Either [
left = Syntax error, insert ";" to complete FieldDeclaration
right = null
]>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at org.eclipse.jdt.ls.core.internal.syntaxserver.SyntaxServerTest.testSyntaxDiagnostics(SyntaxServerTest.java:163)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

[wenytang-ms]

The failure was for SyntaxServerTest: It fails for me without your patch.

Error Details

expected: <Syntax error, insert ";" to complete FieldDeclaration> but was: <Either [ left = Syntax error, insert ";" to complete FieldDeclaration right = null ]>

Stack Trace

org.opentest4j.AssertionFailedError: expected: <Syntax error, insert ";" to complete FieldDeclaration> but was: <Either [ left = Syntax error, insert ";" to complete FieldDeclaration right = null ]> at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145) at org.eclipse.jdt.ls.core.internal.syntaxserver.SyntaxServerTest.testSyntaxDiagnostics(SyntaxServerTest.java:163) at java.base/java.lang.reflect.Method.invoke(Method.java:565) at java.base/java.util.ArrayList.forEach(ArrayList.java:1604) at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

@jjohnstn @datho7561 that's great, please take a look into this PR.

[jjohnstn]

@wenytang-ms I already fixed the test failure.