Add Javadoc quick fix support for overridden methods

[SougandhS]

Enable the "Add Javadoc comment" quick fix for methods that override parent methods. The generated Javadoc includes (non-Javadoc) marker and @see reference to the parent method.

[eclipse-ls-bot]

Can one of the admins verify this patch?

[SougandhS]

the new test - testAddJavadocForOverriddenMethodInRecord
was failing locally with

java.lang.ClassCastException: class org.eclipse.jdt.core.dom.RecordDeclaration cannot be cast to class org.eclipse.jdt.core.dom.TypeDeclaration (org.eclipse.jdt.core.dom.RecordDeclaration and org.eclipse.jdt.core.dom.TypeDeclaration are in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @3da3cc2f)
	at org.eclipse.jdt.internal.corext.refactoring.code.makestatic.ChangeCalculator.generateUniqueParameterName(ChangeCalculator.java:227)
	at org.eclipse.jdt.internal.corext.refactoring.code.makestatic.ChangeCalculator.<init>(ChangeCalculator.java:130)
	at org.eclipse.jdt.internal.corext.refactoring.code.MakeStaticRefactoring.checkFinalConditions(MakeStaticRefactoring.java:177)
	at org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:87)
	at org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:116)
	at org.eclipse.jdt.ls.core.internal.corrections.RefactorProcessor$6.getChange(RefactorProcessor.java:1299)
	at org.eclipse.jdt.ls.core.internal.handlers.CodeActionHandler.getCodeActionFromProposal(CodeActionHandler.java:368)
	at org.eclipse.jdt.ls.core.internal.handlers.CodeActionHandler.getCodeActionCommands(CodeActionHandler.java:246)
	at org.eclipse.jdt.ls.core.internal.correction.AbstractQuickFixTest.evaluateCodeActions(AbstractQuickFixTest.java:316)
	at org.eclipse.jdt.ls.core.internal.correction.AbstractQuickFixTest.evaluateCodeActions(AbstractQuickFixTest.java:293)
	at org.eclipse.jdt.ls.core.internal.correction.AbstractQuickFixTest.assertCodeActions(AbstractQuickFixTest.java:130)
	at org.eclipse.jdt.ls.core.internal.correction.JavadocQuickFixTest.testAddJavadocForOverriddenMethodInRecord(JavadocQuickFixTest.java:1206)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

Its an upstream issue - will be fixed once eclipse-jdt/eclipse.jdt.ui#3045 is merged

[SougandhS]

Will update the other failing tests accordingly

[SougandhS]

Hi @jjohnstn,
Could you please check this when you get some time ?

[SougandhS]

Unrelated build integration test failure :

passing on local

[jjohnstn]

Hi @jjohnstn, Could you please check this when you get some time ?

Hi @SougandhS I was waiting for the jdt.ls release to occur. I still need to bump the release number then it should be fine for review/merge.

[jjohnstn]

Looks good.

[SougandhS]

Hi @SougandhS I was waiting for the jdt.ls release to occur. I still need to bump the release number then it should be fine for review/merge.

Cool 👍

Looks good.

Thanks!