Skip to content

fix(tests): Activate part instead of calling setFocus#1549

Merged
rubenporras merged 1 commit into
eclipse-lsp4e:mainfrom
FlorianKroiss:activate-instead-of-focus
Jun 22, 2026
Merged

fix(tests): Activate part instead of calling setFocus#1549
rubenporras merged 1 commit into
eclipse-lsp4e:mainfrom
FlorianKroiss:activate-instead-of-focus

Conversation

@FlorianKroiss

@FlorianKroiss FlorianKroiss commented Jun 20, 2026

Copy link
Copy Markdown
Contributor
  • IWorkbenchPart.setFocus() should not be called directly. Instead, the part should be activated.
  • Swap arguments of assertEquals to correctly specify actual/expected
  • This fixes the consistently failing tests on ubuntu-latest

Fixes #1485

@FlorianKroiss FlorianKroiss force-pushed the activate-instead-of-focus branch from fae62dd to d623ee2 Compare June 20, 2026 20:39
@FlorianKroiss FlorianKroiss changed the title fix: Activate part instead of calling setFocus fix(tests): Activate part instead of calling setFocus Jun 20, 2026
@FlorianKroiss FlorianKroiss marked this pull request as ready for review June 20, 2026 22:12
@FlorianKroiss

Copy link
Copy Markdown
Contributor Author

@rubenporras I think we can merge this

@rubenporras rubenporras merged commit bf66c94 into eclipse-lsp4e:main Jun 22, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-Enable testFormatOnReadOnlyFileAndMakeWritable for Ubuntu-24.04

2 participants