refactor: move the download ingestion code to analytics.ingestion

[netomi]

Stack: 2 of 6. Split out of #2027. Base: #2130 (split/webui-library-surface).

A pure relocation with no behaviour change, so that the ingestion rework in the next PR is reviewable as a rework rather than as a rework tangled up with a package move.

storage/log/AwsDownloadCountHandler                       -> analytics/ingestion/aws/
storage/log/{CloudFront,Fastly}LogFileParser, LogFileParser, LogRecord
                                                          -> analytics/ingestion/aws/
storage/log/AzureDownloadCountHandler                     -> analytics/ingestion/azure/
storage/log/{DownloadCountProcessor,DownloadCountService}  -> analytics/ingestion/

How to check it is really a no-op

20 files, +22/−18. Git detects all 12 relocated files as renames with content identical, so git diff -M shows only:

• package declarations in the moved files
• imports that used to be same-package and now cross one
• the DownloadCountService mock declarations in the six tests that name it
• one pointcut string, below

Filtering the diff to non-package/non-import lines leaves exactly one hunk.

The one thing that could have broken silently

-@Around("execution(* org.eclipse.openvsx.storage.log.*DownloadCountService.isEnabled(..))")
+@Around("execution(* org.eclipse.openvsx.analytics.ingestion.*DownloadCountService.isEnabled(..))")

DownloadCountServiceAspect matches the package as a string. Nothing in the compiler or the type system would have caught this, and the failure mode is quiet: the mirror stops intercepting isEnabled, and download counting behaves differently only in mirror deployments. This is the concrete argument for separating the move from the rework — inside a 114-file feature PR, that line is invisible.

Class names are deliberately not changed here. The DownloadCountProcessedItem -> DownloadIngestion entity rename comes with a table rename, which is a data migration, so it belongs with the rework rather than with a move.

Verification

compileJava/compileTestJava clean; 371 tests passing across the ingestion, storage, registry, admin, VSCode-adapter and Eclipse-service suites (everything that references the moved classes).

Refs #2027, #2025

[Copilot]

🟢 Approval recommended

The change set is a consistent package relocation with updated references (including the AOP pointcut) and no remaining org.eclipse.openvsx.storage.log references found in the codebase.

Pull request overview

This PR relocates the server-side “download ingestion” implementation from org.eclipse.openvsx.storage.log into the new org.eclipse.openvsx.analytics.ingestion package hierarchy (with AWS/Azure subpackages), aiming to keep subsequent ingestion rework focused and reviewable without mixing in package-move noise.

Changes:

• Moved ingestion service/processor and AWS/Azure handlers into analytics.ingestion packages (package declarations + import rewrites).
• Updated all in-repo references (including tests) to import org.eclipse.openvsx.analytics.ingestion.DownloadCountService.
• Updated the mirror AOP pointcut string to match the new DownloadCountService package.

File summaries

File	Description
server/src/test/resources/org/eclipse/openvsx/analytics/ingestion/aws/fastly.log	Adds Fastly sample log under the new AWS ingestion resource path for tests.
server/src/test/resources/org/eclipse/openvsx/analytics/ingestion/aws/cloudfront.log	Adds CloudFront sample log under the new AWS ingestion resource path for tests.
server/src/test/java/org/eclipse/openvsx/storage/StorageUtilServiceUploadFileTest.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/test/java/org/eclipse/openvsx/storage/StorageUtilServiceTest.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/test/java/org/eclipse/openvsx/RegistryAPITest.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/test/java/org/eclipse/openvsx/eclipse/EclipseServiceTest.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/test/java/org/eclipse/openvsx/analytics/ingestion/aws/FastlyLogFileParserTest.java	Moves test package to analytics.ingestion.aws to match relocated AWS parser code/resources.
server/src/test/java/org/eclipse/openvsx/analytics/ingestion/aws/CloudFrontLogFileParserTest.java	Moves test package to analytics.ingestion.aws to match relocated AWS parser code/resources.
server/src/test/java/org/eclipse/openvsx/admin/AdminAPITest.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/test/java/org/eclipse/openvsx/adapter/VSCodeAPITest.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/main/java/org/eclipse/openvsx/storage/StorageUtilService.java	Updates DownloadCountService import to new analytics ingestion package.
server/src/main/java/org/eclipse/openvsx/mirror/aop/DownloadCountServiceAspect.java	Updates AOP pointcut package string to match relocated DownloadCountService.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/DownloadCountService.java	Relocates service to analytics.ingestion; adds cross-package imports for AWS/Azure handlers.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/DownloadCountProcessor.java	Relocates processor to analytics.ingestion (package declaration update).
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/azure/AzureDownloadCountHandler.java	Relocates Azure handler into analytics.ingestion.azure and adjusts imports accordingly.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/aws/LogRecord.java	Relocates AWS log record model into analytics.ingestion.aws.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/aws/LogFileParser.java	Relocates AWS log parser interface into analytics.ingestion.aws.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/aws/FastlyLogFileParser.java	Relocates Fastly parser into analytics.ingestion.aws.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/aws/CloudFrontLogFileParser.java	Relocates CloudFront parser into analytics.ingestion.aws.
server/src/main/java/org/eclipse/openvsx/analytics/ingestion/aws/AwsDownloadCountHandler.java	Relocates AWS handler into analytics.ingestion.aws and adjusts imports accordingly.

Review details

• Files reviewed: 18/20 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.