Skip to content

Clean Code for ui/org.eclipse.pde.core#2355

Open
eclipse-pde-bot wants to merge 1 commit into
masterfrom
clean-code/ui/org.eclipse.pde.core
Open

Clean Code for ui/org.eclipse.pde.core#2355
eclipse-pde-bot wants to merge 1 commit into
masterfrom
clean-code/ui/org.eclipse.pde.core

Conversation

@eclipse-pde-bot

Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Test Results

 6 files   -   120   6 suites   - 120   14s ⏱️ - 34m 25s
 4 tests  - 3 506   4 ✅  - 3 452  0 💤  -  54  0 ❌ ±0 
12 runs   - 9 321  12 ✅  - 9 191  0 💤  - 130  0 ❌ ±0 

Results for commit d15c64f. ± Comparison against base commit af2b487.

This pull request removes 3506 tests.
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractCommandWithCategory
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractHandlerWithCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractHandlerWithoutCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractPlaceHolder
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractResolveCommandsWithTwoHandledItemsWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractResolveCommandsWithTwoHandlerWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractSinglePart
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoHandlerWithDifferentCommands
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoHandlerWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoPartsSameLocation
…

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.core branch from a1fdafe to d15c64f Compare June 5, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant