Fix/db setup mysql8 - #14
Merged
Merged
Conversation
A fresh install could not connect to the database it had just created. - Bump the generated docker-compose.yaml from datajoint/mysql:5.7 to datajoint/mysql:8. MySQL 5.7 offers only a SHA-1 cipher suite, which current Python refuses to negotiate, so any environment built after PyMySQL 1.2.0 (May 2026) failed with SSLV3_ALERT_HANDSHAKE_FAILURE. On mysql:8 the connection works and is genuinely encrypted. Pinning pymysql<1.2 was rejected: it hides the problem instead of fixing it. - Warn when a data_* directory already exits MYSQL_ROOT_PASSWORD only when initialising an empty data directory, so a leftover one silently kept its old pasin a bare "Access denied for user 'root'". - Use sys.executable rather than a bare `python` when creating schemas.
Resolved src/ethopy/setup_db.py: kept main's _run_import helper and moved this branch's sys.executable fix into it, so both the core schema loop and the new plugin import loop use the interpreter EthoPy is installed in. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GiYtKt18XS7fJCpjhB2iyB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.