Repository navigation
fix: reconcile ValueSelector sidecars during config repack - #21
Open
therealb4n4na wants to merge 1 commit into
Open
therealb4n4na wants to merge 1 commit into
therealb4n4na wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
This PR adds a narrowly scoped, independently verified reconciliation path for visualization sidecars during config push.
What it fixes
When a visualized V178 PushButton2Sel is added, changed, or removed, config push no longer leaves the corresponding LoxAPP3.json and permissions.bin data stale.
The implementation reconciles:
action, FE, jLocked, min, max, step, value, FC, room RightGroup, category RightGroup, FF
Verification
The mapping was independently reproduced from a genuine Loxone Config-authored V178 PushButton2Sel and verified on an isolated development Miniserver.
Verification included:
Safety / scope
This implementation is intentionally limited to the independently verified V178 PushButton2Sel -> ValueSelector case.
It does not:
Unknown or unsupported layouts are not rewritten heuristically.
The percentage-format example from config push preserves stale LoxAPP3.json, leaving new visible controls absent from app #20 is also not generalized here. Our independently Config-authored fixture verifies XML -> LoxAPP3 format %.0f; other display-format mappings need their own evidence.
Tests
The patch adds tests for:
Before submission, the same patch passed: