Skip to content

[Folding] Change condition for meeting target cycles from '<' to '<=' #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpjentzsch merged 1 commit into from
Jan 28, 2025
Merged

[Folding] Change condition for meeting target cycles from '<' to '<=' #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/finn/transformation/fpgadataflow/set_folding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def optimize_attribute_val(self, node_inst, max_val, attr_name):
for val in divisors(max_val):
node_inst.set_nodeattr(attr_name, val)
cyc = node_inst.get_exp_cycles()
if cyc < self.target_cycles_per_frame:
if cyc <= self.target_cycles_per_frame:
# finish if target met
break

Expand Down Expand Up @@ -138,7 +138,7 @@ def apply(self, model):
prev_simd_val = node_inst.get_nodeattr("SIMD")
node_inst.set_nodeattr("SIMD", simd_val)
cyc = node_inst.get_exp_cycles()
if cyc < self.target_cycles_per_frame:
if cyc <= self.target_cycles_per_frame:
# finish if target met
break
if (
Expand Down