Add active terraform dependency collection for automerge classification#1049
Add active terraform dependency collection for automerge classification#1049Copilot wants to merge 2 commits into
terraform dependency collection for automerge classification#1049Conversation
Agent-Logs-Url: https://github.com/elastic/oblt-aw/sessions/b9621ec9-29e4-4f35-a57a-484be55ea4ef Co-authored-by: fr4nc1sc0-r4m0n <215478872+fr4nc1sc0-r4m0n@users.noreply.github.com>
terraform dependency collection for automerge classification
There was a problem hiding this comment.
Pull request overview
Adds an active terraform dependency collection to the Observability automerge dependency-collection classifier so Terraform/OpenTofu/Terragrunt-only dependency update PRs can be routed through the “allowed” automerge path.
Changes:
- Added a new active
terraformcollection with Terraform/OpenTofu/Terragrunt file globs toconfig/obs/automerge-dependency-collections.json. - Added a unit test ensuring terraform-only changed files classify as
{ status: 'allowed', collectionId: 'terraform' }.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/obs/automerge-dependency-collections.json | Adds an active terraform collection with Terraform/OpenTofu/Terragrunt-related file patterns for classification. |
| tests/unit/classifyAutomergeDependencyCollection.test.ts | Adds coverage to verify terraform-only changes are classified as allowed under the new collection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
v1v
left a comment
There was a problem hiding this comment.
Can you confirm with @elastic/observablt-dx if they have any concerns? I don't recall they actually use terraform in any oblt-* repositories but just wanna play safe here
@elastic/observablt-dx do you have any concern about activating this dependency collection to allow the automerge on these related version bumps? |
What effort is this PR part of?. We heavily rely on Terraform on What version will this config bump exactly? |
This is related with this issue https://github.com/elastic/observability-robots/issues/4425.
So basically what we are pretending to do here in natural language is: should we merge automatically the PRs that contains bump versions related with terraform files that are categorized as moderate to low-risk by the dependency review agentic workflow and passes all the additional validations? |
This change adds a dedicated
terraformdependency collection to automerge routing, including Terraform, OpenTofu, and Terragrunt-related files. The new collection is configured as active so terraform-only dependency update PRs can be classified and proceed through automerge gates.Collection config update
terraformentry toconfig/obs/automerge-dependency-collections.json.active: true.**/*.tf**/*.tfvars**/*.tfvars.json**/.terraform.lock.hcl**/terragrunt.hcl**/.opentofu-version**/.terraform-version**/.terragrunt-versionClassifier coverage
tests/unit/classifyAutomergeDependencyCollection.test.tswith a focused unit test that verifies terraform-only changes classify as:status: 'allowed'collectionId: 'terraform'Example config fragment:
{ "id": "terraform", "description": "Terraform/OpenTofu/Terragrunt dependency and lockfile updates", "active": true, "file-glob": [ "**/*.tf", "**/*.tfvars", "**/*.tfvars.json", "**/.terraform.lock.hcl", "**/terragrunt.hcl", "**/.opentofu-version", "**/.terraform-version", "**/.terragrunt-version" ] }