Skip to content

[oblt-aw][security] Fix SEC-010 Semgrep mapping misclassification#995

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
fix/sec010-semgrep-mapping-988-16650972890dacb2
Draft

[oblt-aw][security] Fix SEC-010 Semgrep mapping misclassification#995
github-actions[bot] wants to merge 1 commit into
mainfrom
fix/sec010-semgrep-mapping-988-16650972890dacb2

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Closes #988

This remediates SEC-010 finding classification drift by fixing Semgrep check_id mapping in scripts/obs/security-scan.sh.

What changed

  • Updated Semgrep rule mapping in scripts/obs/security-scan.sh:
    • hardcoded.*(secret|token|credential) -> SEC-020
    • secret|token|credential -> SEC-002
    • injection|template|insecure -> SEC-010
    • fallback -> SEC-012
  • Added regression test tests/test_security_scan_semgrep_mapping.py to lock mapping behavior.
  • Updated docs to match implementation:
    • docs/workflows/gh-aw-security-detector.md
    • docs/workflows/security-scanning-ruleset.md

Resolution plan checklist

  • Identify and fix SEC mapping root cause in detector implementation
  • Add deterministic regression coverage
  • Validate repository test suites
  • Update security detector docs/ruleset traceability

Validation evidence

/tmp/gh-aw/agent/venv/bin/python -m pytest tests/
95 passed in 0.18s

npm test --silent
6 passed, 0 failed

Security requirements confirmation

  • Least-privilege: no workflow/job permissions were broadened; this PR only changes detector mapping logic, tests, and docs.
  • Env-indirection: no secret/token interpolation was introduced in workflow run: command strings.

Note

🔒 Integrity filter blocked 41 items

The following items were blocked because they don't meet the GitHub integrity level.

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

What is this? | From workflow: Observability Agentic Workflow Entrypoint

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Correct semgrep check_id to SEC mapping in scripts/obs/security-scan.sh so secret/credential findings are not misclassified as SEC-010 injection findings. Add regression coverage and update detector docs/ruleset traceability accordingly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[oblt-aw][security] SEC-010 — findings (2026-05-21)

0 participants