set tag to main#16
Conversation
* add workflow update workflow add default value to workflow inputs update workflow testing default values test run update workflow update pin ansible version ansible ver ansible ver ansible-core ver update workflow update remove custom role (temporary) add azure build step add SP login update azure envs fix typo add cache add key testing azure add gh token fix cache update workflow seperate jobs update update logs remove cahce from azure test update update fix typo add artifact upload update store step update path add store workflow add input add install openstckclient fix fix command add image-builder workflow fix branch name testing sed typo create tag quotes echo fix add docker login update openstack to use container remove checkout change workflow update .dockerignore update workflow add option testing binbash hostname test test try deps testing testing typo test enable kvm add logs env TEST test mount mount change mount change kvm testing upload artifact update mount rw add user mdkir privileged test testing enable azure add elastx store update storing inherit secrets fix naming add safespring store add safespring store change auth safespring verbose change openstack final add sshca role testing enable image builder update builder add sshca role build new image run build add volume testing add docker image add envs final1 * cleanup * revert dockerfiles to main * add patch step * remove get tag * remove sshca role * remove patched step from Dockerfile * remove default values
simonklb
left a comment
simonklb
left a comment
There was a problem hiding this comment.
The PR description is a bit lacking. What is this and why are you doing it?
|
this fixes the building of the 'image-builder' from the main branch, i missed this change from the previous PR. |
| run: make docker-build | ||
| env: | ||
| TAG: ${{ steps.get-tag.outputs.TAG }} | ||
| TAG: main |
There was a problem hiding this comment.
Suggestion: This would overwrite the main tag each time? Wouldn't we also want the commit hash to be able to use older builds if needed?
Maybe both, so you can reference the latest build with main but also have a copy of each commit?
There was a problem hiding this comment.
We can create an issue for that as a CI task
| run: make docker-build | ||
| env: | ||
| TAG: ${{ steps.get-tag.outputs.TAG }} | ||
| TAG: main |
There was a problem hiding this comment.
Question: Can't find this target in the root Makefile. I assume this is this target. If so wouldn't we need to add this?
| TAG: main | |
| TAG: main | |
| working-directory: ./images/capi |
There was a problem hiding this comment.
I might have unintentionally removed the working-directory
5 participants
Change description
Related issues
Additional context