Fix stale Codex auth state in desktop#4460
Merged
Merged
Conversation
Contributor
kevin-dp
force-pushed
the
fix/codex-stale-auth
branch
from
a02884b to
cc5745b
Compare
kevin-dp
approved these changes
Jun 2, 2026
| } | ||
|
|
||
| async function clearCodexAuth( | ||
| deps: Pick< |
Contributor
There was a problem hiding this comment.
This Picked type is the most precise but also verbose and requires more maintenance (any time one of these props changes). I would keep it simple here: deps: CodexAuthDeps
|
|
||
| export async function syncCodexEnvironment( | ||
| deps: Pick<CodexAuthDeps, `settings` | `getSecretStore`> | ||
| deps: Pick< |
Contributor
There was a problem hiding this comment.
Same comment as before, simplify to: deps: CodexAuthDeps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test