Skip to content

Better partition Bullwinkle.Package and bullwinkle messages sent "over the wire" #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deldrid1 wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Better partition Bullwinkle.Package and bullwinkle messages sent "over the wire" #20

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fb1c863
Bump Version
deldrid1 Sep 27, 2016
d07ea66
Add prependID to settings
deldrid1 Sep 27, 2016
e58d826
Allow custom timestamps to be used with .send(name, data, ts)
deldrid1 Sep 27, 2016
348fd2c
Move message.tries into package._tries
deldrid1 Sep 27, 2016
dabe747
Move _packageTimeout into its own workflow and call immediately if th…
deldrid1 Sep 27, 2016
4784503
Revert "Add prependID to settings"
deldrid1 Sep 27, 2016
e2149af
Bug fixes identified during testing
deldrid1 Oct 3, 2016
e5d00f7
Bug fix for usage on Agent
deldrid1 Oct 4, 2016
adb215a
Add lowMemoryThreshold setting to address #18.
deldrid1 Oct 4, 2016
82ce3b4
Bug fix for messages not calling their onFail handlers after a timeout
deldrid1 Oct 5, 2016
b9b0155
Add _checkTimer for all imp.wakeup's
deldrid1 Oct 5, 2016
5e91b88
Add firstMessageID setting to Bullwinkle.
deldrid1 Oct 5, 2016
b1514ce
bugfix for ts
deldrid1 Nov 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bullwinkle.class.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const BULLWINKLE_WATCHDOG_TIMER = 0.5;


class Bullwinkle {
static version = [2,3,1];
static version = [2,3,2];

@blindman2k blindman2k Oct 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:
static version = [2,4,0];

@deldrid1 deldrid1 Oct 6, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on where the pull request ends up, it might ought to be [3,0,0]...

@blindman2k blindman2k Oct 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may reserve v3.0.0 for a complete rewrite :)

@deldrid1 deldrid1 Oct 7, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just (more than gently) trying to nudge you in that direction ;)

@blindman2k blindman2k Oct 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the one you need to convince 😸


// The bullwinkle message
static BULLWINKLE = "bullwinkle";
Expand Down