Restart does not close old Electron instance

[kasper9n]

Problem

My app has a before-quit handler which waits for the webview to be ready. But when the plugin makes Electron restart, the webview page/code is gone, so it can't tell the app to finish quitting. This means I end up with many Electron instances running at the same time

Solution

Keep the Vite webpage loaded until the app quits

Workaround

Disable restarting:

onstart({ startup }) {
  if (process.electronApp) {
    console.log('\x1b[35mNot restarting\x1b[0m')
  } else {
    startup()
  }
}

[yejimeiming]

This problem happened before, and we solved it using treeKillSync.
Do you still have similar problems on you local machine?

vite-plugin-electron/src/index.ts

Line 166 in 149c4a9

treeKillSync(process.electronApp.pid!)

vite-plugin-electron/src/utils.ts

Lines 144 to 150 in 149c4a9

	export function treeKillSync(pid: number) {
	if (process.platform === 'win32') {
	cp.execSync(`taskkill /pid ${pid} /T /F`)
	} else {
	killTree(pidTree({ pid, ppid: process.pid }))
	}
	}

[kasper9n]

Yes I do have the problem on the latest version (v0.28.7).

However, it works if I call treeKillSync in my own Vite config, or even just process.kill(process.electronApp.pid):

onstart({ startup }) {
	if (process.electronApp) {
		treeKillSync(process.electronApp.pid)
		// or
		process.kill(process.electronApp.pid)
	}
	startup()
},

It would be neat if it did a graceful shutdown with SIGTERM by waiting for the child_process to exit

[yejimeiming]

@probablykasper Would you like to test the following changes locally?

vite-plugin-electron/src/utils.ts

Line 179 in 149c4a9

process.kill(tree.pid) // #214

function killTree(tree: PidTree) {
  if (tree.children) {
    for (const child of tree.children) {
      killTree(child)
    }
  }

  try {
-   process.kill(tree.pid) // #214
+   process.kill(tree.pid, 'SIGKILL') // Force kill process
  } catch { /* empty */ }
}

[kasper9n]

That does work. Personally I would prefer waiting for the child process to exit though instead of force quitting

[kasper9n]

Here's a working solution without force quitting:

startup.exit = async () => {
  if (process.electronApp) {
    process.electronApp.removeAllListeners();
    process.kill(process.electronApp.pid, 'SIGTERM');
    await new Promise((resolve) => {
      process.electronApp.once("exit", resolve);
    })
  }
};

[kasper9n]

Yes, it works for me. But I don't know how you want to incorporate treeKillSync

[yejimeiming]

Maybe you could try this for me, it should work fine.
treeKillSync is required, we need to take care of people using Windows systems.

startup.exit = async () => {
  if (process.electronApp) {
    await new Promise((resolve) => {
      process.electronApp.removeAllListeners()
      process.electronApp.once('exit', resolve)
      treeKillSync(process.electronApp.pid!)
    })
  }
}

[yejimeiming]

v0.28.8 will be released in about an hour and a half.

[kasper9n]

That does not work unfortunately. It doesn't quit, and gives me this error:

[47765:0919/044144.460406:ERROR:gpu_process_host.cc(993)] GPU process exited unexpectedly: exit_code=15
[47765:0919/044144.468629:ERROR:network_service_instance_impl.cc(601)] Network service crashed, restarting service.

[yejimeiming]

Are you working on Mac OS?
It's worked on my Mac OS.

[yejimeiming]

The same error happened to me, but vite-plugin-electron still works fine. This error is thrown by Electron, it's not caused by us.

[kasper9n]

I am on macOS, yes. Are you testing with a before-quit handler like I use though?
https://github.com/probablykasper/ferrum/blob/7ac23dd2ca8fa397e51355aab6e0283f2e11be5a/src/electron/main.ts#L151-L168